Skip to content

[fix](test) fix unstable refresh catalog/db ut #38352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Jul 25, 2024
Merged

[fix](test) fix unstable refresh catalog/db ut #38352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fe/fe-core/src/test/java/org/apache/doris/catalog/RefreshDbTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ public void testRefreshDatabase() throws Exception {
}
long l3 = db1.getLastUpdateTime();
Assertions.assertTrue(l3 == l2);
// when use_meta_cache is true, the table will be recreated after refresh.
// so we need to get table again
table = db1.getTable("tbl11").get();
Assertions.assertFalse(table.isObjectCreated());
test1.getDbNullable("db1").getTables();
Assertions.assertFalse(table.isObjectCreated());
Expand Down
7 changes: 5 additions & 2 deletions fe/fe-core/src/test/java/org/apache/doris/datasource/RefreshCatalogTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,12 @@ public void testRefreshCatalogLastUpdateTime() throws Exception {
// not triggered init method
long l3 = test2.getLastUpdateTime();
Assertions.assertTrue(l3 == l2);
// Assertions.assertFalse(table.isObjectCreated());
// when use_meta_cache is true, the table will be recreated after refresh.
// so we need to get table again
table = (TestExternalTable) test2.getDbNullable("db1").getTable("tbl11").get();
Assertions.assertFalse(table.isObjectCreated());
test2.getDbNullable("db1").getTables();
// Assertions.assertFalse(table.isObjectCreated());
Assertions.assertFalse(table.isObjectCreated());
try {
DdlExecutor.execute(Env.getCurrentEnv(), refreshCatalogStmt);
} catch (Exception e) {
Expand Down