Skip to content

Conversation

@cambyzju
Copy link
Contributor

pick #38287 to branch-2.1

Proposed changes

Issue Number: close #xxx

Compare primary key without sequence column is expensive,
if full key is exact_match, the primary key without sequence column
should also the same,
do not need to compare again.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.44% (9254/25397)
Line Coverage: 27.99% (75653/270285)
Region Coverage: 26.80% (38883/145101)
Branch Coverage: 23.52% (19726/83864)
Coverage Report: http://coverage.selectdb-in.cc/coverage/63f9e6f0d8a79472684102a81a978b4bfef9611b_63f9e6f0d8a79472684102a81a978b4bfef9611b/report/index.html

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 29, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@cambyzju cambyzju merged commit 715bcd1 into apache:branch-2.1 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants