Skip to content

[fix](csv reader) fix csv parser incorrect if enclosing line_delimiter (#38347) #38446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liaoxin01 merged 1 commit into from
Jul 29, 2024
Merged

[fix](csv reader) fix csv parser incorrect if enclosing line_delimiter (#38347) #38446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions be/src/vec/exec/format/file_reader/new_plain_text_line_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,11 @@ void EncloseCsvLineReaderContext::_on_pre_match_enclose(const uint8_t* start, si
if (_idx != _total_len) {
len = update_reading_bound(start);
} else {
// It needs to set the result to nullptr for matching enclose may not be read
// after reading the output buf.
// Therefore, if the result is not set to nullptr,
// the parser will consider reading a line as there is a line delimiter.
_result = nullptr;
break;
}
} while (true);
Expand Down