Skip to content

[fix](nereids) fix The children format needs to be [WhenClause+, DefaultValue?] #38491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 8 commits into from
Jul 30, 2024
Merged

[fix](nereids) fix The children format needs to be [WhenClause+, DefaultValue?] #38491

starocean999 merged 8 commits into from
Jul 30, 2024

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Jul 29, 2024

Proposed changes

fix The children format needs to be [WhenClause+, DefaultValue?]

@doris-robot
Copy link

doris-robot commented Jul 29, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@924060929
Copy link
Contributor Author

924060929 commented Jul 29, 2024

run buildall

@924060929
Copy link
Contributor Author

924060929 commented Jul 29, 2024

run buildall

@924060929
Copy link
Contributor Author

924060929 commented Jul 29, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jul 29, 2024

TPC-H: Total hot run time: 41608 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7290ebb3c5a5ee0148d54cf1089f9fd23612266b, data reload: false

------ Round 1 ----------------------------------
q1	18134	4195	4094	4094
q2	2016	207	206	206
q3	10456	1305	1318	1305
q4	10180	810	902	810
q5	7616	2912	2949	2912
q6	219	143	143	143
q7	1024	610	615	610
q8	9433	1801	1928	1801
q9	8476	6603	6570	6570
q10	8693	3817	3829	3817
q11	436	251	256	251
q12	412	234	235	234
q13	17758	2971	2960	2960
q14	267	242	248	242
q15	541	489	478	478
q16	478	384	385	384
q17	954	929	908	908
q18	8076	7364	7338	7338
q19	1371	1219	1213	1213
q20	580	332	353	332
q21	5315	4710	4778	4710
q22	355	296	290	290
Total cold run time: 112790 ms
Total hot run time: 41608 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4041	3995	3991	3991
q2	329	224	225	224
q3	2975	2999	2990	2990
q4	1903	1888	1887	1887
q5	5252	5212	5223	5212
q6	216	131	131	131
q7	2046	1666	1637	1637
q8	3238	3346	3279	3279
q9	8300	8282	8275	8275
q10	3777	3822	3795	3795
q11	543	451	451	451
q12	734	549	555	549
q13	16758	2950	2932	2932
q14	277	254	269	254
q15	513	480	473	473
q16	448	397	388	388
q17	1725	1697	1680	1680
q18	7692	7244	7149	7149
q19	1650	1675	1676	1675
q20	1957	1759	1741	1741
q21	5445	5189	5197	5189
q22	528	479	482	479
Total cold run time: 70347 ms
Total hot run time: 54381 ms

@doris-robot
Copy link

doris-robot commented Jul 29, 2024

TPC-DS: Total hot run time: 169312 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7290ebb3c5a5ee0148d54cf1089f9fd23612266b, data reload: false

query1	919	371	376	371
query2	6476	1784	1729	1729
query3	6678	213	219	213
query4	19705	17386	17220	17220
query5	4288	529	531	529
query6	268	179	172	172
query7	4603	321	299	299
query8	254	197	197	197
query9	8529	2416	2395	2395
query10	468	280	277	277
query11	10514	10016	9890	9890
query12	145	92	90	90
query13	1644	385	390	385
query14	10266	7223	7630	7223
query15	211	162	165	162
query16	7118	471	442	442
query17	966	565	545	545
query18	1920	282	290	282
query19	197	149	147	147
query20	87	85	87	85
query21	205	102	101	101
query22	4209	3955	4043	3955
query23	33713	32962	33074	32962
query24	10399	3097	3069	3069
query25	713	397	383	383
query26	1802	153	152	152
query27	2987	282	284	282
query28	6978	1981	1970	1970
query29	1364	420	415	415
query30	286	148	152	148
query31	950	773	741	741
query32	102	56	81	56
query33	718	321	324	321
query34	944	489	490	489
query35	870	745	721	721
query36	1017	867	853	853
query37	303	81	80	80
query38	2834	2749	2768	2749
query39	877	799	811	799
query40	284	118	113	113
query41	49	45	44	44
query42	124	98	107	98
query43	488	430	420	420
query44	1214	720	721	720
query45	207	179	176	176
query46	1079	812	800	800
query47	1771	1676	1703	1676
query48	373	296	291	291
query49	1187	443	449	443
query50	929	440	450	440
query51	6753	6653	6639	6639
query52	100	96	89	89
query53	266	194	186	186
query54	662	464	471	464
query55	75	79	75	75
query56	302	260	264	260
query57	1158	1051	1030	1030
query58	333	278	310	278
query59	2607	2475	2408	2408
query60	300	279	273	273
query61	98	96	102	96
query62	954	672	650	650
query63	218	188	183	183
query64	5885	1915	1947	1915
query65	3145	3117	3090	3090
query66	1469	348	343	343
query67	15214	14906	14683	14683
query68	4350	575	595	575
query69	455	297	314	297
query70	1112	1032	1055	1032
query71	409	280	292	280
query72	7194	2750	2500	2500
query73	777	333	336	333
query74	6041	5647	5600	5600
query75	3433	2760	2730	2730
query76	2622	1346	1466	1346
query77	499	316	329	316
query78	9438	8903	8934	8903
query79	1541	550	554	550
query80	1193	533	527	527
query81	596	233	230	230
query82	1072	143	135	135
query83	260	177	184	177
query84	285	87	85	85
query85	1393	379	420	379
query86	392	319	324	319
query87	3246	3093	3097	3093
query88	3067	2467	2498	2467
query89	397	304	290	290
query90	1811	197	198	197
query91	131	115	105	105
query92	62	53	53	53
query93	1433	639	622	622
query94	894	306	309	306
query95	382	275	276	275
query96	606	284	279	279
query97	3198	3004	3095	3004
query98	216	201	202	201
query99	1676	1326	1324	1324
Total cold run time: 263952 ms
Total hot run time: 169312 ms

@924060929
Copy link
Contributor Author

924060929 commented Jul 29, 2024

run buildall

@924060929
Copy link
Contributor Author

924060929 commented Jul 29, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jul 29, 2024

TPC-H: Total hot run time: 41827 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ed375bc7ac40e414fa7f001434c01332dddc5879, data reload: false

------ Round 1 ----------------------------------
q1	18148	4291	4214	4214
q2	2578	208	234	208
q3	10935	1318	1330	1318
q4	10218	791	984	791
q5	8219	3040	3010	3010
q6	227	141	140	140
q7	1058	624	618	618
q8	9794	1859	1903	1859
q9	8424	6595	6599	6595
q10	8695	3852	3820	3820
q11	429	258	250	250
q12	414	240	230	230
q13	17762	2922	2921	2921
q14	277	245	244	244
q15	527	488	491	488
q16	496	399	385	385
q17	963	922	951	922
q18	8030	7220	7348	7220
q19	1391	1225	1224	1224
q20	593	331	340	331
q21	5410	4750	4889	4750
q22	349	291	289	289
Total cold run time: 114937 ms
Total hot run time: 41827 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4055	4024	4062	4024
q2	335	223	233	223
q3	2984	2984	2985	2984
q4	1876	1833	1848	1833
q5	5252	5236	5193	5193
q6	217	131	131	131
q7	2022	1715	1704	1704
q8	3220	3310	3273	3273
q9	8282	8286	8264	8264
q10	3758	3863	3836	3836
q11	547	445	436	436
q12	710	546	555	546
q13	13251	2949	2966	2949
q14	287	261	267	261
q15	527	476	477	476
q16	444	404	402	402
q17	1726	1685	1664	1664
q18	7750	7280	7204	7204
q19	1700	1675	1666	1666
q20	1957	1741	1766	1741
q21	5617	5157	5256	5157
q22	522	457	460	457
Total cold run time: 67039 ms
Total hot run time: 54424 ms

@doris-robot
Copy link

doris-robot commented Jul 29, 2024

TPC-DS: Total hot run time: 169608 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ed375bc7ac40e414fa7f001434c01332dddc5879, data reload: false

query1	919	368	364	364
query2	6475	1691	1640	1640
query3	6657	214	219	214
query4	20211	17323	17332	17323
query5	4299	525	512	512
query6	294	179	169	169
query7	4614	305	297	297
query8	265	195	204	195
query9	8513	2395	2412	2395
query10	453	276	269	269
query11	10475	10051	9887	9887
query12	143	87	89	87
query13	1611	384	382	382
query14	8982	7927	7918	7918
query15	209	164	169	164
query16	7089	457	418	418
query17	944	574	546	546
query18	1909	277	280	277
query19	189	162	144	144
query20	91	85	84	84
query21	203	104	101	101
query22	4047	3891	3859	3859
query23	33899	33006	32781	32781
query24	10303	3058	3065	3058
query25	689	414	386	386
query26	1793	147	147	147
query27	3027	271	272	271
query28	7047	1998	1972	1972
query29	1345	422	420	420
query30	283	149	153	149
query31	935	775	740	740
query32	107	58	53	53
query33	712	310	316	310
query34	934	482	494	482
query35	887	739	726	726
query36	1002	859	865	859
query37	305	79	78	78
query38	2904	2792	2778	2778
query39	859	801	831	801
query40	277	115	112	112
query41	79	52	44	44
query42	119	96	106	96
query43	473	415	422	415
query44	1198	718	718	718
query45	205	183	178	178
query46	1089	812	781	781
query47	1802	1699	1706	1699
query48	356	292	295	292
query49	1195	427	413	413
query50	900	439	453	439
query51	6751	6737	6709	6709
query52	105	88	90	88
query53	254	180	178	178
query54	658	452	468	452
query55	76	76	76	76
query56	279	257	253	253
query57	1165	1007	1035	1007
query58	285	281	262	262
query59	2560	2329	2398	2329
query60	298	276	275	275
query61	103	98	100	98
query62	945	657	676	657
query63	210	183	187	183
query64	5874	1915	1956	1915
query65	3145	3085	3074	3074
query66	1442	347	337	337
query67	15269	14797	15013	14797
query68	4350	576	583	576
query69	445	297	293	293
query70	1097	1054	1084	1054
query71	381	296	285	285
query72	7143	2733	2505	2505
query73	771	332	333	332
query74	6070	5671	5735	5671
query75	3387	2714	2727	2714
query76	2301	1358	1390	1358
query77	446	311	304	304
query78	9419	8936	8915	8915
query79	1944	532	546	532
query80	1211	572	512	512
query81	579	229	226	226
query82	1160	128	132	128
query83	241	179	178	178
query84	274	77	84	77
query85	1337	337	317	317
query86	450	299	321	299
query87	3262	3104	3130	3104
query88	3016	2485	2497	2485
query89	431	307	288	288
query90	1776	191	192	191
query91	124	104	104	104
query92	66	52	56	52
query93	1564	640	624	624
query94	926	302	295	295
query95	394	269	272	269
query96	615	287	287	287
query97	3192	3087	3025	3025
query98	229	199	194	194
query99	1646	1283	1281	1281
Total cold run time: 262982 ms
Total hot run time: 169608 ms

@924060929
Copy link
Contributor Author

924060929 commented Jul 29, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jul 29, 2024

TPC-H: Total hot run time: 41465 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 39f9f1c7da65e5277423a8c3b5ad128dd77067a2, data reload: false

------ Round 1 ----------------------------------
q1	17598	4074	4002	4002
q2	2019	208	218	208
q3	10440	1308	1339	1308
q4	10185	809	901	809
q5	7660	2943	2962	2943
q6	220	139	138	138
q7	1032	608	606	606
q8	9434	1904	1941	1904
q9	8473	6563	6599	6563
q10	8702	3831	3822	3822
q11	437	253	253	253
q12	410	222	227	222
q13	17758	2948	2934	2934
q14	276	252	246	246
q15	526	487	489	487
q16	486	384	389	384
q17	956	902	916	902
q18	8025	7247	7161	7161
q19	1387	1211	1354	1211
q20	588	320	350	320
q21	5347	4800	4762	4762
q22	345	280	290	280
Total cold run time: 112304 ms
Total hot run time: 41465 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4039	3983	4002	3983
q2	326	223	223	223
q3	2976	2983	2995	2983
q4	1854	1881	1853	1853
q5	5271	5183	5205	5183
q6	216	133	131	131
q7	2083	1723	1680	1680
q8	3213	3336	3275	3275
q9	8322	8293	8300	8293
q10	3754	3835	3792	3792
q11	544	449	459	449
q12	739	583	542	542
q13	15771	2961	2941	2941
q14	286	259	252	252
q15	525	475	482	475
q16	437	393	386	386
q17	1715	1683	1684	1683
q18	7731	7362	7122	7122
q19	1652	1671	1656	1656
q20	1976	1775	1756	1756
q21	5503	5149	5193	5149
q22	513	466	465	465
Total cold run time: 69446 ms
Total hot run time: 54272 ms

@doris-robot
Copy link

doris-robot commented Jul 29, 2024

TPC-DS: Total hot run time: 169978 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 39f9f1c7da65e5277423a8c3b5ad128dd77067a2, data reload: false

query1	919	365	369	365
query2	6470	1660	1626	1626
query3	6674	209	220	209
query4	20020	17427	17391	17391
query5	4303	499	523	499
query6	293	162	160	160
query7	4604	321	299	299
query8	262	187	198	187
query9	8508	2413	2405	2405
query10	449	280	278	278
query11	10536	10005	9974	9974
query12	139	84	84	84
query13	1608	373	384	373
query14	9451	8593	7892	7892
query15	206	161	161	161
query16	7096	456	433	433
query17	946	549	565	549
query18	1910	282	287	282
query19	195	151	143	143
query20	89	82	84	82
query21	204	105	103	103
query22	4203	3980	3955	3955
query23	34066	32976	33006	32976
query24	10353	3127	3045	3045
query25	710	376	387	376
query26	1743	155	149	149
query27	2954	285	283	283
query28	6930	1998	1985	1985
query29	1310	421	417	417
query30	277	148	151	148
query31	945	764	760	760
query32	98	54	57	54
query33	699	310	318	310
query34	922	469	500	469
query35	839	746	717	717
query36	980	877	831	831
query37	298	80	82	80
query38	2876	2760	2779	2760
query39	872	807	841	807
query40	312	113	110	110
query41	51	44	44	44
query42	123	102	104	102
query43	477	400	415	400
query44	1211	727	723	723
query45	204	176	179	176
query46	1107	806	778	778
query47	1797	1729	1724	1724
query48	359	290	291	290
query49	1165	414	410	410
query50	911	439	441	439
query51	6827	6715	6603	6603
query52	103	99	93	93
query53	260	185	191	185
query54	640	458	459	458
query55	76	77	77	77
query56	279	255	248	248
query57	1168	1026	1050	1026
query58	295	274	273	273
query59	2718	2351	2397	2351
query60	349	285	274	274
query61	99	99	97	97
query62	934	669	664	664
query63	221	190	182	182
query64	5891	1930	1921	1921
query65	3148	3082	3081	3081
query66	1455	356	352	352
query67	15305	14666	14733	14666
query68	4336	577	594	577
query69	461	309	360	309
query70	1093	1072	1073	1072
query71	417	291	283	283
query72	7136	2706	2570	2570
query73	782	331	334	331
query74	6073	5668	5656	5656
query75	3386	2741	2782	2741
query76	2246	1366	1424	1366
query77	441	317	311	311
query78	9427	9019	8920	8920
query79	1490	544	540	540
query80	1227	502	514	502
query81	542	225	226	225
query82	1123	137	130	130
query83	239	169	170	169
query84	275	80	81	80
query85	1298	313	308	308
query86	393	299	306	299
query87	3304	3132	3138	3132
query88	3051	2578	2502	2502
query89	394	290	285	285
query90	1768	200	195	195
query91	128	104	106	104
query92	64	52	50	50
query93	1457	627	633	627
query94	885	305	301	301
query95	387	266	277	266
query96	610	283	281	281
query97	3205	3043	2998	2998
query98	211	204	194	194
query99	1660	1331	1290	1290
Total cold run time: 262951 ms
Total hot run time: 169978 ms

@doris-robot
Copy link

doris-robot commented Jul 29, 2024

ClickBench: Total hot run time: 29.81 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 39f9f1c7da65e5277423a8c3b5ad128dd77067a2, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.04
query4	1.69	0.07	0.06
query5	0.48	0.48	0.49
query6	1.13	0.72	0.71
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.58	0.51	0.52
query10	0.57	0.55	0.56
query11	0.15	0.11	0.12
query12	0.14	0.12	0.13
query13	0.61	0.59	0.60
query14	0.78	0.80	0.78
query15	0.91	0.86	0.86
query16	0.35	0.35	0.34
query17	1.00	1.02	0.98
query18	0.22	0.21	0.22
query19	1.90	1.72	1.68
query20	0.01	0.01	0.01
query21	15.40	0.80	0.68
query22	3.68	7.39	1.22
query23	17.85	1.41	1.28
query24	2.26	0.23	0.22
query25	0.18	0.09	0.09
query26	0.32	0.21	0.21
query27	0.47	0.24	0.24
query28	13.15	0.99	0.95
query29	12.54	3.33	3.33
query30	0.26	0.06	0.06
query31	2.86	0.40	0.41
query32	3.27	0.49	0.47
query33	2.90	3.02	2.95
query34	15.42	4.28	4.21
query35	4.30	4.28	4.27
query36	0.67	0.48	0.49
query37	0.19	0.16	0.16
query38	0.16	0.16	0.15
query39	0.05	0.03	0.03
query40	0.17	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 107.23 s
Total hot run time: 29.81 s

@wm1581066 wm1581066 added the usercase Important user case type label label Jul 30, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 21a3db6 into apache:master Jul 30, 2024
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Jul 30, 2024
@924060929
[fix](nereids) fix The children format needs to be [WhenClause+, Defa…
1fbd22f 
…ultValue?] (apache#38491)

fix The children format needs to be [WhenClause+, DefaultValue?]

(cherry picked from commit 21a3db6)
@924060929 924060929 mentioned this pull request Jul 30, 2024
Merged
924060929 added a commit that referenced this pull request Jul 30, 2024
@924060929
[fix](nereids) fix The children format needs to be [WhenClause+, Defa…
1ba1e34 
…ultValue?] (#38491) (#38546)

fix The children format needs to be [WhenClause+, DefaultValue?]
@924060929 924060929 mentioned this pull request Aug 2, 2024
Merged
924060929 added a commit that referenced this pull request Aug 2, 2024
@924060929
[fix](nereids) fix The children format needs to be [WhenClause+, Defa…
62fff8e 
…ultValue?] (#38491) (#38778)

fix The children format needs to be [WhenClause+, DefaultValue?]
dataroaring pushed a commit that referenced this pull request Aug 2, 2024
@924060929 @dataroaring
[fix](nereids) fix The children format needs to be [WhenClause+, Defa…
8c3c82f 
…ultValue?] (#38491)

fix The children format needs to be [WhenClause+, DefaultValue?]
feiniaofeiafei pushed a commit to feiniaofeiafei/doris that referenced this pull request Aug 9, 2024
@924060929 @feiniaofeiafei
[fix](nereids) fix The children format needs to be [WhenClause+, Defa…
b3f4bf3 
…ultValue?] (apache#38491)

fix The children format needs to be [WhenClause+, DefaultValue?]
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@924060929 @Baymine
[fix](nereids) fix The children format needs to be [WhenClause+, Defa…
99fc40f 
…ultValue?] (apache#38491) (apache#38778)

fix The children format needs to be [WhenClause+, DefaultValue?]
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Closed
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.14-merged dev/2.1.6-merged dev/3.0.1-merged p0_b reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@924060929 @doris-robot @starocean999 @morrySnow @wm1581066 @dataroaring