[feature] (expr) support expression IS [NOT] TURE/FALSE #38623

justfortaste · 2024-07-31T12:54:41Z

support expression IS [NOT] TURE/FALSE

mysql> select 1 is true, 1 is not true, 0 is true, 0 is not true;
+--------------------+---------------------------+--------------------+---------------------------+
| cast(1 as BOOLEAN) | ( not cast(1 as BOOLEAN)) | cast(0 as BOOLEAN) | ( not cast(0 as BOOLEAN)) |
+--------------------+---------------------------+--------------------+---------------------------+
|                  1 |                         0 |                  0 |                         1 |
+--------------------+---------------------------+--------------------+---------------------------+

doris-robot · 2024-07-31T12:54:46Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

fe/fe-core/src/main/java/org/apache/doris/backup/Untitled-2.cs

fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java

regression-test/suites/nereids_syntax_p0/sql/test_compare_expression.sql

nextdreamblue · 2024-08-01T11:29:33Z

run buildall

doris-robot · 2024-08-01T12:07:01Z

TPC-H: Total hot run time: 41792 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ccd0b8fe8755536756c44f1b094a30104a0c924c, data reload: false

------ Round 1 ----------------------------------
q1	18531	4090	4058	4058
q2	2014	196	196	196
q3	10448	1223	1317	1223
q4	10645	816	928	816
q5	7928	3065	2991	2991
q6	221	139	140	139
q7	1042	629	622	622
q8	9576	1983	1935	1935
q9	8538	6645	6687	6645
q10	9022	4017	4058	4017
q11	1826	267	268	267
q12	1302	234	234	234
q13	18807	2958	2965	2958
q14	267	252	244	244
q15	531	499	498	498
q16	544	397	387	387
q17	966	936	919	919
q18	9694	7229	7145	7145
q19	1922	1217	1207	1207
q20	528	339	338	338
q21	5276	4753	4674	4674
q22	348	279	282	279
Total cold run time: 119976 ms
Total hot run time: 41792 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4104	4014	4023	4014
q2	340	245	228	228
q3	3126	3168	3087	3087
q4	2021	2005	1943	1943
q5	5472	5389	5455	5389
q6	226	139	136	136
q7	2187	1807	1766	1766
q8	3349	3360	3301	3301
q9	8517	8807	8618	8618
q10	3876	3948	4032	3948
q11	558	462	468	462
q12	740	603	598	598
q13	13565	3136	3137	3136
q14	304	272	267	267
q15	532	476	491	476
q16	475	410	415	410
q17	1730	1720	1753	1720
q18	8226	7719	7706	7706
q19	2021	1733	1716	1716
q20	2130	1835	1845	1835
q21	5610	5293	5501	5293
q22	498	485	485	485
Total cold run time: 69607 ms
Total hot run time: 56534 ms

doris-robot · 2024-08-01T12:17:40Z

TPC-DS: Total hot run time: 168561 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ccd0b8fe8755536756c44f1b094a30104a0c924c, data reload: false

query1	920	381	373	373
query2	6417	1729	1723	1723
query3	6652	226	238	226
query4	20316	17422	17398	17398
query5	3711	519	511	511
query6	266	176	172	172
query7	4589	310	300	300
query8	263	200	203	200
query9	8508	2343	2357	2343
query10	431	287	263	263
query11	10524	10035	9959	9959
query12	121	95	86	86
query13	1662	374	374	374
query14	10037	6387	6894	6387
query15	205	160	166	160
query16	6955	429	440	429
query17	938	563	541	541
query18	1890	284	295	284
query19	192	142	147	142
query20	88	83	86	83
query21	196	97	97	97
query22	4322	3964	3892	3892
query23	33879	33691	33284	33284
query24	10153	3147	3063	3063
query25	674	405	411	405
query26	1695	161	160	160
query27	2969	281	289	281
query28	7481	2026	1989	1989
query29	1300	435	437	435
query30	237	157	152	152
query31	965	779	741	741
query32	100	53	57	53
query33	665	321	318	318
query34	922	487	507	487
query35	886	776	743	743
query36	1064	937	887	887
query37	291	84	87	84
query38	3006	2903	2764	2764
query39	863	815	816	815
query40	253	114	114	114
query41	47	44	44	44
query42	124	97	99	97
query43	481	422	427	422
query44	1182	723	722	722
query45	206	177	181	177
query46	1106	789	794	789
query47	1786	1707	1713	1707
query48	377	287	299	287
query49	932	420	426	420
query50	880	433	426	426
query51	6737	6722	6624	6624
query52	107	88	89	88
query53	261	201	184	184
query54	620	452	451	451
query55	75	76	78	76
query56	267	267	249	249
query57	1123	1043	1052	1043
query58	279	268	286	268
query59	2529	2352	2506	2352
query60	295	278	311	278
query61	131	90	90	90
query62	896	672	660	660
query63	216	185	179	179
query64	5640	1900	1870	1870
query65	3150	3114	3096	3096
query66	1334	334	334	334
query67	15176	14868	15044	14868
query68	4290	555	571	555
query69	472	287	299	287
query70	1132	1094	1068	1068
query71	367	295	282	282
query72	7242	2671	2508	2508
query73	756	329	332	329
query74	5991	5699	5685	5685
query75	3370	2764	2733	2733
query76	2107	1227	1268	1227
query77	410	299	308	299
query78	9383	9118	8855	8855
query79	1947	525	543	525
query80	1165	510	506	506
query81	563	228	226	226
query82	1061	139	131	131
query83	239	168	170	168
query84	261	83	75	75
query85	1256	313	304	304
query86	450	279	315	279
query87	3267	3053	3081	3053
query88	2891	2407	2414	2407
query89	387	297	296	296
query90	1705	203	195	195
query91	123	99	100	99
query92	64	52	49	49
query93	1698	618	611	611
query94	825	301	291	291
query95	386	265	265	265
query96	605	284	278	278
query97	3253	3073	3011	3011
query98	215	260	189	189
query99	1654	1291	1256	1256
Total cold run time: 262098 ms
Total hot run time: 168561 ms

doris-robot · 2024-08-01T12:23:09Z

ClickBench: Total hot run time: 30.53 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ccd0b8fe8755536756c44f1b094a30104a0c924c, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.04
query4	1.68	0.06	0.06
query5	0.49	0.49	0.48
query6	1.13	0.72	0.73
query7	0.02	0.01	0.01
query8	0.06	0.05	0.04
query9	0.56	0.52	0.51
query10	0.57	0.56	0.56
query11	0.15	0.11	0.11
query12	0.14	0.12	0.13
query13	0.62	0.59	0.60
query14	0.78	0.80	0.79
query15	0.92	0.86	0.87
query16	0.35	0.35	0.36
query17	0.97	0.99	1.01
query18	0.22	0.21	0.21
query19	1.90	1.75	1.75
query20	0.02	0.01	0.01
query21	15.40	0.77	0.65
query22	3.93	6.48	1.93
query23	17.91	1.27	1.20
query24	2.09	0.24	0.22
query25	0.19	0.08	0.08
query26	0.31	0.21	0.22
query27	0.45	0.22	0.22
query28	13.17	0.99	0.97
query29	12.53	3.32	3.29
query30	0.25	0.06	0.06
query31	2.88	0.40	0.41
query32	3.23	0.48	0.48
query33	3.11	2.97	2.95
query34	15.41	4.26	4.26
query35	4.28	4.29	4.28
query36	0.67	0.48	0.47
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.15	0.12	0.13
query41	0.10	0.05	0.05
query42	0.06	0.04	0.06
query43	0.04	0.04	0.04
Total cold run time: 107.47 s
Total hot run time: 30.53 s

github-actions · 2024-08-01T13:13:19Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-01T13:13:21Z

PR approved by anyone and no changes requested.

924060929 · 2024-08-01T13:16:21Z

run buildall

doris-robot · 2024-08-01T13:54:10Z

TPC-H: Total hot run time: 41332 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7e8331574827cfee4ee7d47db45c7ba94d8d2d86, data reload: false

------ Round 1 ----------------------------------
q1	17647	4090	3998	3998
q2	2013	193	195	193
q3	10462	1351	1325	1325
q4	10165	850	963	850
q5	7632	2869	2940	2869
q6	221	138	137	137
q7	1111	638	626	626
q8	9429	1821	1900	1821
q9	8535	6570	6545	6545
q10	8745	3831	3911	3831
q11	430	258	254	254
q12	445	236	234	234
q13	17779	2939	2919	2919
q14	267	244	245	244
q15	529	471	476	471
q16	535	389	387	387
q17	962	919	918	918
q18	7992	7265	7211	7211
q19	1586	1214	1211	1211
q20	561	338	342	338
q21	5248	4677	4669	4669
q22	346	281	289	281
Total cold run time: 112640 ms
Total hot run time: 41332 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4065	3985	4027	3985
q2	325	222	223	222
q3	3001	2968	3091	2968
q4	1972	1989	2012	1989
q5	5553	5469	5439	5439
q6	221	131	138	131
q7	2119	1789	1795	1789
q8	3303	3385	3316	3316
q9	8716	8652	8764	8652
q10	3966	4024	3957	3957
q11	541	457	454	454
q12	780	602	565	565
q13	14260	3111	3133	3111
q14	301	300	265	265
q15	535	481	510	481
q16	486	412	408	408
q17	1743	1697	1715	1697
q18	8114	7850	7707	7707
q19	1773	1714	1690	1690
q20	2136	1892	1834	1834
q21	5720	5473	5255	5255
q22	534	469	465	465
Total cold run time: 70164 ms
Total hot run time: 56380 ms

doris-robot · 2024-08-01T14:04:51Z

TPC-DS: Total hot run time: 169999 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7e8331574827cfee4ee7d47db45c7ba94d8d2d86, data reload: false

query1	904	377	372	372
query2	6457	1755	1688	1688
query3	6654	223	240	223
query4	19262	17385	17446	17385
query5	3663	500	508	500
query6	254	168	174	168
query7	4595	299	292	292
query8	253	201	203	201
query9	8512	2372	2363	2363
query10	430	288	264	264
query11	10544	10071	9981	9981
query12	120	90	89	89
query13	1640	401	372	372
query14	9526	7419	7540	7419
query15	199	159	163	159
query16	6819	428	469	428
query17	928	556	541	541
query18	1886	275	281	275
query19	186	160	142	142
query20	91	86	86	86
query21	201	99	96	96
query22	4323	3980	3980	3980
query23	33782	33690	33574	33574
query24	10447	3163	3212	3163
query25	694	398	430	398
query26	1853	165	152	152
query27	3023	288	284	284
query28	7543	1998	2004	1998
query29	1280	429	436	429
query30	245	166	156	156
query31	996	802	779	779
query32	105	60	58	58
query33	658	316	322	316
query34	927	486	515	486
query35	868	759	711	711
query36	1001	856	852	852
query37	278	79	76	76
query38	2911	2814	2756	2756
query39	882	818	819	818
query40	260	111	114	111
query41	45	44	44	44
query42	118	101	97	97
query43	490	419	418	418
query44	1174	737	725	725
query45	206	177	177	177
query46	1077	852	811	811
query47	1807	1711	1699	1699
query48	369	290	296	290
query49	937	436	425	425
query50	889	433	443	433
query51	6856	6717	6743	6717
query52	99	91	96	91
query53	248	178	178	178
query54	622	440	448	440
query55	81	79	81	79
query56	285	275	271	271
query57	1150	1035	1022	1022
query58	321	288	267	267
query59	2588	2331	2343	2331
query60	291	269	271	269
query61	95	92	95	92
query62	883	651	654	651
query63	218	182	180	180
query64	5656	1922	1865	1865
query65	3152	3098	3090	3090
query66	1311	338	328	328
query67	15410	14911	14762	14762
query68	4251	566	582	566
query69	425	301	320	301
query70	1095	1055	1042	1042
query71	362	287	286	286
query72	7169	2672	2526	2526
query73	765	331	332	331
query74	6100	5611	5620	5611
query75	3360	2769	2701	2701
query76	2170	1235	1283	1235
query77	416	310	312	310
query78	9423	8861	8900	8861
query79	2146	536	558	536
query80	1126	519	500	500
query81	562	226	221	221
query82	1072	130	129	129
query83	240	172	167	167
query84	268	80	87	80
query85	1280	327	310	310
query86	454	320	279	279
query87	3233	3107	3133	3107
query88	2950	2418	2402	2402
query89	398	293	297	293
query90	1679	194	194	194
query91	126	99	169	99
query92	61	49	49	49
query93	2034	618	619	618
query94	828	290	306	290
query95	384	270	268	268
query96	618	279	286	279
query97	3256	3031	3030	3030
query98	222	208	196	196
query99	1629	1293	1289	1289
Total cold run time: 261680 ms
Total hot run time: 169999 ms

doris-robot · 2024-08-01T14:10:20Z

ClickBench: Total hot run time: 30.47 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7e8331574827cfee4ee7d47db45c7ba94d8d2d86, data reload: false

query1	0.05	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.69	0.06	0.07
query5	0.49	0.48	0.48
query6	1.14	0.72	0.71
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.58	0.51	0.50
query10	0.57	0.55	0.57
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.62	0.60	0.59
query14	0.78	0.78	0.78
query15	0.91	0.87	0.86
query16	0.35	0.36	0.35
query17	1.00	0.99	1.00
query18	0.22	0.21	0.21
query19	1.83	1.72	1.72
query20	0.02	0.01	0.01
query21	15.43	0.77	0.66
query22	3.89	6.74	1.87
query23	17.96	1.31	1.24
query24	2.27	0.22	0.22
query25	0.18	0.08	0.08
query26	0.31	0.22	0.22
query27	0.45	0.24	0.23
query28	13.14	1.00	0.97
query29	12.60	3.34	3.31
query30	0.26	0.05	0.05
query31	2.89	0.41	0.41
query32	3.23	0.50	0.48
query33	2.91	2.95	2.89
query34	15.43	4.28	4.26
query35	4.31	4.30	4.35
query36	0.67	0.48	0.49
query37	0.19	0.17	0.15
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.15	0.13	0.13
query41	0.09	0.04	0.04
query42	0.06	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 107.6 s
Total hot run time: 30.47 s

support expression IS [NOT] TURE/FALSE ``` mysql> select 1 is true, 1 is not true, 0 is true, 0 is not true; +--------------------+---------------------------+--------------------+---------------------------+ | cast(1 as BOOLEAN) | ( not cast(1 as BOOLEAN)) | cast(0 as BOOLEAN) | ( not cast(0 as BOOLEAN)) | +--------------------+---------------------------+--------------------+---------------------------+ | 1 | 0 | 0 | 1 | +--------------------+---------------------------+--------------------+---------------------------+ ```

justfortaste force-pushed the feature_expr_is_true branch from bd93f8c to fa4f241 Compare July 31, 2024 12:59

morrySnow reviewed Jul 31, 2024

View reviewed changes

justfortaste force-pushed the feature_expr_is_true branch from fa4f241 to 86296cd Compare July 31, 2024 13:39

github-actions bot added the doing label Aug 1, 2024

justfortaste force-pushed the feature_expr_is_true branch from 1e600ee to 77b6f8f Compare August 1, 2024 07:58

justfortaste requested a review from morrySnow August 1, 2024 10:17

[feature] (expr) support expression IS [NOT] TURE/FALSE

ccd0b8f

justfortaste force-pushed the feature_expr_is_true branch from 4d43330 to ccd0b8f Compare August 1, 2024 11:12

cast as boolean

7e83315

morrySnow approved these changes Aug 1, 2024

View reviewed changes

morrySnow removed the doing label Aug 1, 2024

github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 1, 2024

github-actions bot added the reviewed label Aug 1, 2024

924060929 approved these changes Aug 1, 2024

View reviewed changes

nextdreamblue merged commit ac089b1 into apache:master Aug 2, 2024

nextdreamblue added dev/2.0.x dev/2.1.x dev/3.0.x labels Aug 2, 2024

dataroaring removed the dev/3.0.x label Aug 26, 2024

dataroaring added the dev/3.0.2-merged label Aug 26, 2024

gavinchou mentioned this pull request Oct 13, 2024

Release Note 3.0.2 #41558

Closed

[feature] (expr) support expression IS [NOT] TURE/FALSE #38623

[feature] (expr) support expression IS [NOT] TURE/FALSE #38623

Uh oh!

Conversation

justfortaste commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doris-robot commented Jul 31, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nextdreamblue commented Aug 1, 2024

Uh oh!

doris-robot commented Aug 1, 2024

Uh oh!

doris-robot commented Aug 1, 2024

Uh oh!

doris-robot commented Aug 1, 2024

Uh oh!

github-actions bot commented Aug 1, 2024

Uh oh!

github-actions bot commented Aug 1, 2024

Uh oh!

924060929 commented Aug 1, 2024

Uh oh!

doris-robot commented Aug 1, 2024

Uh oh!

doris-robot commented Aug 1, 2024

Uh oh!

doris-robot commented Aug 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

justfortaste commented Jul 31, 2024 •

edited

Loading