[pick](json-keys) support json_keys function #38631
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| const char* l_raw = reinterpret_cast<const char*>(&ldata[l_off]); | ||
| JsonbDocument* doc = JsonbDocument::createDocument(l_raw, l_size); | ||
| if (UNLIKELY(!doc || !doc->getValue())) { |
There was a problem hiding this comment.
warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
if (UNLIKELY(!doc || !doc->getValue())) {
^Additional context
be/src/common/compiler_util.h:35: expanded from macro 'UNLIKELY'
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^| dst_arr.insert_default(); | ||
| continue; | ||
| } | ||
| ObjectVal* obj = (ObjectVal*)obj_val; |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
| ObjectVal* obj = (ObjectVal*)obj_val; | |
| auto* obj = (ObjectVal*)obj_val; |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
3 participants
Proposed changes
backport: #36411
Issue Number: close #xxx