-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](fe) Fix the default value of ReplacePartitionClause.isStrictRange #38688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 41905 ms |
TPC-DS: Total hot run time: 169238 ms |
ClickBench: Total hot run time: 30.03 s |
During ReplacePartitionClause.analyze(), the default value of isStrictRange is true. However, ReplacePartitionClause instances constructed by internal code do not call analyze(), so their isStrictRange value is incorrect (e.g., INSERT INTO ... OVERWRITE). This PR handle the relevant properties when constructing ReplacePartitionClause.
6bc3da0 to
6cd0f80
Compare
|
run buildall |
TPC-H: Total hot run time: 42077 ms |
TPC-DS: Total hot run time: 168545 ms |
ClickBench: Total hot run time: 30.05 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…ge (apache#38688) During ReplacePartitionClause.analyze(), the default value of isStrictRange is true. However, ReplacePartitionClause instances constructed by internal code do not call analyze(), so their isStrictRange value is incorrect (e.g., INSERT INTO ... OVERWRITE). This PR handle the relevant properties when constructing ReplacePartitionClause.
…ge (apache#38688) During ReplacePartitionClause.analyze(), the default value of isStrictRange is true. However, ReplacePartitionClause instances constructed by internal code do not call analyze(), so their isStrictRange value is incorrect (e.g., INSERT INTO ... OVERWRITE). This PR handle the relevant properties when constructing ReplacePartitionClause.
…ge (#38688) During ReplacePartitionClause.analyze(), the default value of isStrictRange is true. However, ReplacePartitionClause instances constructed by internal code do not call analyze(), so their isStrictRange value is incorrect (e.g., INSERT INTO ... OVERWRITE). This PR handle the relevant properties when constructing ReplacePartitionClause.
…ge (#38688) During ReplacePartitionClause.analyze(), the default value of isStrictRange is true. However, ReplacePartitionClause instances constructed by internal code do not call analyze(), so their isStrictRange value is incorrect (e.g., INSERT INTO ... OVERWRITE). This PR handle the relevant properties when constructing ReplacePartitionClause.
During ReplacePartitionClause.analyze(), the default value of isStrictRange is true. However, ReplacePartitionClause instances constructed by internal code do not call analyze(), so their isStrictRange value is incorrect (e.g., INSERT INTO ... OVERWRITE).
This PR handle the relevant properties when constructing ReplacePartitionClause.