[fix](clone) fix stale tablet report miss the new cloning replica #38695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
be/src/olap/task/engine_clone_task.h
Outdated
| std::vector<TTabletInfo>* tablet_infos); | ||
| ~EngineCloneTask() override = default; | ||
|
|
||
| public: |
Contributor
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
Suggested change
| public: |
Additional context
be/src/olap/task/engine_clone_task.h:49: previously declared here
public:
^
TPC-H: Total hot run time: 41337 ms |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 169973 ms |
github-actions
bot
removed
the
approved
ClickBench: Total hot run time: 30.05 s |
Contributor
Author
|
run external |
Contributor
Author
|
run buildall |
yujun777
force-pushed
the
fix-clone-new-tablet-report-version
branch
from
eb8087f to
3fc4f8e
Compare
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run performance |
TPC-H: Total hot run time: 41295 ms |
TPC-DS: Total hot run time: 169677 ms |
ClickBench: Total hot run time: 29.61 s |
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
…8695) BUG: 1. BE begin collect tablet report; 2. BE clone a new replica A; 3. FE handle this BE's tablet report from step 1. But it's stale, it don't include the replica A, then FE mark replica A as bad; only after 1min later, BE report tablets again, then the new report contains replica A, only after that, FE will change replica A from bad to good. Fix: If BE clone a new replica, it should increase its report version and tell FE to update it. Then if FE handle the stale tablet report, it will compare BE's report version, then found the tablet report is stale and discard it.
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
…8695) BUG: 1. BE begin collect tablet report; 2. BE clone a new replica A; 3. FE handle this BE's tablet report from step 1. But it's stale, it don't include the replica A, then FE mark replica A as bad; only after 1min later, BE report tablets again, then the new report contains replica A, only after that, FE will change replica A from bad to good. Fix: If BE clone a new replica, it should increase its report version and tell FE to update it. Then if FE handle the stale tablet report, it will compare BE's report version, then found the tablet report is stale and discard it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG:
only after 1min later, BE report tablets again, then the new report contains replica A, only after that, FE will change replica A from bad to good.
Fix:
If BE clone a new replica, it should increase its report version and tell FE to update it. Then if FE handle the stale tablet report, it will compare BE's report version, then found the tablet report is stale and discard it.