-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[BUG] fix partition storage policy info lost #38700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 42044 ms |
TPC-DS: Total hot run time: 170492 ms |
ClickBench: Total hot run time: 29.94 s |
|
run buildall |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 39749 ms |
TPC-DS: Total hot run time: 201023 ms |
ClickBench: Total hot run time: 30.65 s |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## Proposed changes
1. fix partition storage policy info lost
When adding a storage policy to a table through an alter statement, the
partition policy is lost when the FE is restarted because the storage
policy is not set for the partition synchronously.
2. when setting policies, check the uniq table in advance to prevent
metadata inconsistencies
3. show storage policy using for stmt support any string policy name
If the policy name begins with a number, the statement cannot be parsed.
Issue Number: close #xxx
<!--Describe your changes.-->
---------
Co-authored-by: garenshi <garenshi@tencent.com>
## Proposed changes cherry-pick from #38700 Issue Number: close #xxx <!--Describe your changes.--> --------- ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> Co-authored-by: garenshi <garenshi@tencent.com>
## Proposed changes
1. fix partition storage policy info lost
When adding a storage policy to a table through an alter statement, the
partition policy is lost when the FE is restarted because the storage
policy is not set for the partition synchronously.
2. when setting policies, check the uniq table in advance to prevent
metadata inconsistencies
3. show storage policy using for stmt support any string policy name
If the policy name begins with a number, the statement cannot be parsed.
Issue Number: close #xxx
<!--Describe your changes.-->
---------
Co-authored-by: garenshi <garenshi@tencent.com>
Proposed changes
fix partition storage policy info lost
When adding a storage policy to a table through an alter statement, the partition policy is lost when the FE is restarted because the storage policy is not set for the partition synchronously.
when setting policies, check the uniq table in advance to prevent metadata inconsistencies
show storage policy using for stmt support any string policy name
If the policy name begins with a number, the statement cannot be parsed.
Issue Number: close #xxx