Skip to content

Conversation

@HappenLee
Copy link
Contributor

Proposed changes

fix coredump case in (not null, null) execpt (not null, t null) case, column not null insert from nullable column cause coredump

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the doing label Aug 1, 2024
@HappenLee
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41547 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8365eedf8a54adb8137dd7b05580095f4deea1e2, data reload: false

------ Round 1 ----------------------------------
q1	17663	4138	4066	4066
q2	2027	198	197	197
q3	10466	1342	1360	1342
q4	10201	798	913	798
q5	8161	2947	3013	2947
q6	223	138	139	138
q7	1048	612	613	612
q8	9426	1855	1945	1855
q9	8430	6550	6572	6550
q10	8710	3816	3801	3801
q11	448	249	250	249
q12	406	222	220	220
q13	17845	2973	2976	2973
q14	276	247	245	245
q15	520	481	493	481
q16	522	395	381	381
q17	958	908	899	899
q18	8027	7274	7229	7229
q19	1497	1216	1210	1210
q20	547	320	342	320
q21	5321	4756	4764	4756
q22	348	281	278	278
Total cold run time: 113070 ms
Total hot run time: 41547 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4042	3999	4022	3999
q2	327	224	221	221
q3	2975	2985	2993	2985
q4	1862	1869	1848	1848
q5	5221	5215	5214	5214
q6	222	130	129	129
q7	2067	1674	1716	1674
q8	3164	3256	3237	3237
q9	8256	8206	8241	8206
q10	3730	3792	3815	3792
q11	548	448	445	445
q12	719	579	539	539
q13	13085	2957	2948	2948
q14	291	252	270	252
q15	526	488	476	476
q16	445	395	398	395
q17	1726	1678	1671	1671
q18	7774	7404	7259	7259
q19	1657	1658	1661	1658
q20	1967	1757	1763	1757
q21	5471	5256	5181	5181
q22	510	455	443	443
Total cold run time: 66585 ms
Total hot run time: 54329 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 167420 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8365eedf8a54adb8137dd7b05580095f4deea1e2, data reload: false

query1	920	374	364	364
query2	6486	1710	1731	1710
query3	6672	216	228	216
query4	20182	17481	17364	17364
query5	4329	509	530	509
query6	282	172	170	170
query7	4607	303	296	296
query8	251	205	197	197
query9	8504	2349	2334	2334
query10	433	274	269	269
query11	10409	9995	10005	9995
query12	139	91	84	84
query13	1634	384	380	380
query14	9940	6714	6289	6289
query15	233	159	170	159
query16	7117	453	486	453
query17	988	573	549	549
query18	1920	283	285	283
query19	200	161	146	146
query20	95	84	86	84
query21	209	100	101	100
query22	4388	4010	3977	3977
query23	33810	33030	33087	33030
query24	10331	3027	3053	3027
query25	692	376	392	376
query26	1782	147	150	147
query27	2980	274	272	272
query28	7026	1945	1947	1945
query29	1349	419	421	419
query30	292	148	158	148
query31	935	743	756	743
query32	102	52	56	52
query33	702	299	307	299
query34	923	467	470	467
query35	845	722	687	687
query36	1000	858	854	854
query37	294	78	77	77
query38	2835	2787	2760	2760
query39	876	794	795	794
query40	292	111	110	110
query41	46	46	49	46
query42	132	99	103	99
query43	462	413	422	413
query44	1154	721	717	717
query45	211	177	176	176
query46	1079	804	772	772
query47	1804	1751	1710	1710
query48	353	299	293	293
query49	1177	413	420	413
query50	905	428	420	420
query51	6767	6673	6683	6673
query52	97	99	89	89
query53	251	180	174	174
query54	631	439	453	439
query55	82	76	77	76
query56	282	262	263	262
query57	1157	1040	1037	1037
query58	266	263	265	263
query59	2608	2247	2331	2247
query60	303	275	274	274
query61	96	123	99	99
query62	929	652	662	652
query63	215	176	184	176
query64	5888	1903	1860	1860
query65	3165	3087	3082	3082
query66	1436	360	337	337
query67	15333	14883	14693	14693
query68	4366	560	578	560
query69	434	299	297	297
query70	1065	1040	1023	1023
query71	420	278	270	270
query72	7165	2728	2494	2494
query73	761	341	333	333
query74	6000	5596	5625	5596
query75	3391	2689	2724	2689
query76	2677	1189	1275	1189
query77	434	317	309	309
query78	9397	8862	8784	8784
query79	2730	527	537	527
query80	1231	507	505	505
query81	590	230	226	226
query82	973	134	132	132
query83	241	168	178	168
query84	277	80	89	80
query85	1394	316	300	300
query86	444	291	291	291
query87	3300	3083	3059	3059
query88	3905	2390	2400	2390
query89	378	286	288	286
query90	1872	185	192	185
query91	122	102	98	98
query92	66	52	50	50
query93	2161	611	604	604
query94	937	284	288	284
query95	369	265	264	264
query96	608	284	274	274
query97	3236	3060	3030	3030
query98	221	215	198	198
query99	1645	1298	1298	1298
Total cold run time: 266643 ms
Total hot run time: 167420 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8365eedf8a54adb8137dd7b05580095f4deea1e2, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.23	0.04	0.04
query4	1.70	0.07	0.06
query5	0.49	0.48	0.49
query6	1.13	0.71	0.71
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.56	0.53	0.50
query10	0.56	0.56	0.56
query11	0.15	0.12	0.12
query12	0.14	0.12	0.13
query13	0.61	0.60	0.59
query14	0.76	0.80	0.80
query15	0.89	0.87	0.86
query16	0.35	0.36	0.35
query17	0.99	0.99	0.98
query18	0.21	0.21	0.20
query19	1.83	1.73	1.72
query20	0.01	0.01	0.03
query21	15.48	0.79	0.65
query22	5.48	7.85	1.13
query23	18.12	1.40	1.34
query24	2.26	0.23	0.22
query25	0.18	0.08	0.08
query26	0.31	0.22	0.21
query27	0.46	0.22	0.24
query28	13.17	0.99	0.97
query29	12.53	3.31	3.33
query30	0.25	0.06	0.05
query31	2.86	0.40	0.40
query32	3.26	0.51	0.48
query33	2.88	2.94	2.93
query34	15.52	4.25	4.25
query35	4.28	4.29	4.25
query36	0.69	0.47	0.48
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.03
query40	0.15	0.13	0.12
query41	0.10	0.06	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.28 s
Total hot run time: 29.8 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants