[fix](group commit) fix repaly wal check label status #38883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41220 ms |
TPC-DS: Total hot run time: 168565 ms |
ClickBench: Total hot run time: 29.68 s |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41510 ms |
TPC-DS: Total hot run time: 168462 ms |
ClickBench: Total hot run time: 29.84 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
bobhan1
approved these changes
Aug 5, 2024
Yukang-Lian
approved these changes
Aug 6, 2024
mymeiyi
added a commit
to mymeiyi/doris
that referenced
this pull request
Aug 7, 2024
When replay wal, it firstly abort the txn with the label but does not check the abort result. And when begin txn of replay, if FE returns `LabelAlreadyUsedException`, it consider the load is success in previous group commit load or repaly wal, and delete this wal directly. But `LabelAlreadyUsedException` means there is a txn with this label, the txn may be in `PREPARE / RUNNING / COMMITTED / VISIBLE` status(the abort txn in first step may fail), so replay wal should check both `LabelAlreadyUsedException` and txn status is `COMMITTED / VISIBLE`. This pr also add a case for replay wal with schema change.
yiguolei
pushed a commit
that referenced
this pull request
Aug 7, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 7, 2024
## Proposed changes When replay wal, it firstly abort the txn with the label but does not check the abort result. And when begin txn of replay, if FE returns `LabelAlreadyUsedException`, it consider the load is success in previous group commit load or repaly wal, and delete this wal directly. But `LabelAlreadyUsedException` means there is a txn with this label, the txn may be in `PREPARE / RUNNING / COMMITTED / VISIBLE` status(the abort txn in first step may fail), so replay wal should check both `LabelAlreadyUsedException` and txn status is `COMMITTED / VISIBLE`. This pr also add a case for replay wal with schema change.
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
## Proposed changes When replay wal, it firstly abort the txn with the label but does not check the abort result. And when begin txn of replay, if FE returns `LabelAlreadyUsedException`, it consider the load is success in previous group commit load or repaly wal, and delete this wal directly. But `LabelAlreadyUsedException` means there is a txn with this label, the txn may be in `PREPARE / RUNNING / COMMITTED / VISIBLE` status(the abort txn in first step may fail), so replay wal should check both `LabelAlreadyUsedException` and txn status is `COMMITTED / VISIBLE`. This pr also add a case for replay wal with schema change.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When replay wal, it firstly abort the txn with the label but does not check the abort result.
And when begin txn of replay, if FE returns
LabelAlreadyUsedException, it consider the load is success in previous group commit load or repaly wal, and delete this wal directly.But
LabelAlreadyUsedExceptionmeans there is a txn with this label, the txn may be inPREPARE / RUNNING / COMMITTED / VISIBLEstatus(the abort txn in first step may fail), so replay wal should check bothLabelAlreadyUsedExceptionand txn status isCOMMITTED / VISIBLE.This pr also add a case for replay wal with schema change.