-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](schema-change) Fix wrong intput column for cast validity check #38894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](schema-change) Fix wrong intput column for cast validity check #38894
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
07e9ec9 to
aa72d72
Compare
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TPC-H: Total hot run time: 41645 ms |
TPC-DS: Total hot run time: 168525 ms |
ClickBench: Total hot run time: 29.89 s |
aa72d72 to
a2baaf3
Compare
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TPC-H: Total hot run time: 41864 ms |
TPC-DS: Total hot run time: 168798 ms |
ClickBench: Total hot run time: 30.59 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…pache#38894) 1. Use column idx of ref block instead of new block to indicate the ref column. 2. Rename some variables to clarify their meanings. 3. Clarify some log msg. 4. Add a minimal case to verify the change.
…38894) ## Proposed changes 1. Use column idx of ref block instead of new block to indicate the ref column. 2. Rename some variables to clarify their meanings. 3. Clarify some log msg. 4. Add a minimal case to verify the change.
…pache#38894) ## Proposed changes 1. Use column idx of ref block instead of new block to indicate the ref column. 2. Rename some variables to clarify their meanings. 3. Clarify some log msg. 4. Add a minimal case to verify the change.
…38894) ## Proposed changes 1. Use column idx of ref block instead of new block to indicate the ref column. 2. Rename some variables to clarify their meanings. 3. Clarify some log msg. 4. Add a minimal case to verify the change.
Proposed changes