[opt](bytebuffer) allocate ByteBuffer memory by Allocator and make it exception safe #38960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 41429 ms |
TPC-DS: Total hot run time: 168884 ms |
ClickBench: Total hot run time: 30 s |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41825 ms |
TPC-DS: Total hot run time: 169861 ms |
ClickBench: Total hot run time: 30.24 s |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
TPC-H: Total hot run time: 41622 ms |
TPC-DS: Total hot run time: 168590 ms |
ClickBench: Total hot run time: 29.84 s |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41470 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39161 ms |
TPC-DS: Total hot run time: 202548 ms |
ClickBench: Total hot run time: 30.91 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
liaoxin01
approved these changes
Aug 12, 2024
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
… exception safe (apache#38960) At present, the memory allocation of `ByteBuffer` is done through `new char[capacity_]`. Now, it is uniformly allocated by `Allocator` for the following purposes: 1. Better memory statistics 2. Better support for memory limit check
dataroaring
pushed a commit
that referenced
this pull request
Aug 17, 2024
… exception safe (#38960) At present, the memory allocation of `ByteBuffer` is done through `new char[capacity_]`. Now, it is uniformly allocated by `Allocator` for the following purposes: 1. Better memory statistics 2. Better support for memory limit check
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Sep 9, 2024
… exception safe (apache#38960) At present, the memory allocation of `ByteBuffer` is done through `new char[capacity_]`. Now, it is uniformly allocated by `Allocator` for the following purposes: 1. Better memory statistics 2. Better support for memory limit check
liaoxin01
pushed a commit
that referenced
this pull request
Sep 11, 2024
) fix allocate size improper in append_and_flush introduced by #38960
xinyiZzz
pushed a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 14, 2024
… exception safe (apache#38960) At present, the memory allocation of `ByteBuffer` is done through `new char[capacity_]`. Now, it is uniformly allocated by `Allocator` for the following purposes: 1. Better memory statistics 2. Better support for memory limit check
yiguolei
added a commit
that referenced
this pull request
Sep 15, 2024
yiguolei
pushed a commit
that referenced
this pull request
Sep 24, 2024
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
) fix allocate size improper in append_and_flush introduced by #38960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the memory allocation of
ByteBufferis done throughnew char[capacity_]. Now, it is uniformly allocated byAllocatorfor the following purposes: