-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Improvement](inverted index) lazy init inverted index file reader #38979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41544 ms |
TPC-DS: Total hot run time: 169779 ms |
ClickBench: Total hot run time: 29.96 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41302 ms |
TPC-DS: Total hot run time: 168034 ms |
ClickBench: Total hot run time: 29.85 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
qidaye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zzzxl1993
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csun5285
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H: Total hot run time: 41223 ms |
TPC-DS: Total hot run time: 168581 ms |
ClickBench: Total hot run time: 29.99 s |
…38979) ## Proposed changes We call InvertedIndexFileReader::init in segment_iterator init_inverted_index_iterators now, which cause searcher cache miss. So we lazy init when we open specific index.
…pache#38979) ## Proposed changes We call InvertedIndexFileReader::init in segment_iterator init_inverted_index_iterators now, which cause searcher cache miss. So we lazy init when we open specific index.
…38979) ## Proposed changes We call InvertedIndexFileReader::init in segment_iterator init_inverted_index_iterators now, which cause searcher cache miss. So we lazy init when we open specific index.
Proposed changes
We call InvertedIndexFileReader::init in segment_iterator init_inverted_index_iterators now, which cause searcher cache miss.
So we lazy init when we open specific index.