Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Aug 8, 2024

…38731)

#38731
The stddev function has a separate implementation for the DecimalV2 type, but there are issues with the implementation. Given that there is almost no existing data for DecimalV2, it will be removed here. For be, upgrading to this situation will result in an error directly.

SELECT STDDEV(data) FROM DECIMALV2_10_0_DATA;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]Agg Function stddev(decimal(10,0)) is not implemented

After removing DecimalV2, parameters of type DecimalV2 will be converted to double for calculations.

Proposed changes

Issue Number: close #xxx

…pache#38731)

The stddev function has a separate implementation for the DecimalV2
type, but there are issues with the implementation. Given that there is
almost no existing data for DecimalV2, it will be removed here. For be,
upgrading to this situation will result in an error directly.
```
SELECT STDDEV(data) FROM DECIMALV2_10_0_DATA;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]Agg Function stddev(decimal(10,0)) is not implemented
```
After removing DecimalV2, parameters of type DecimalV2 will be converted
to double for calculations.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented Aug 8, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.38% (9259/25450)
Line Coverage: 27.85% (75645/271593)
Region Coverage: 26.73% (38948/145718)
Branch Coverage: 23.42% (19750/84312)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5616c23de5c5dcc48265c168feb3c38843c13ac3_5616c23de5c5dcc48265c168feb3c38843c13ac3/report/index.html

@yiguolei yiguolei merged commit efdd75f into apache:branch-2.1 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants