[Performance](opt) opt the order by performance in permutation #39089
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #pragma once | ||
|
|
||
| #include <glog/logging.h> |
There was a problem hiding this comment.
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
#include <glog/logging.h>
^| std::partial_sort(res.begin(), sort_end, res.end(), | ||
| [this](size_t a, size_t b) { return data[a] < data[b]; }); | ||
| } else { | ||
| if (reverse) |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| if (reverse) | |
| if (reverse) { |
be/src/vec/columns/column_decimal.h:301:
- else
+ } else| if (reverse) | ||
| pdqsort(res.begin(), res.end(), | ||
| [this](size_t a, size_t b) { return data[a] > data[b]; }); | ||
| else |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| else | |
| else { |
be/src/vec/columns/column_decimal.h:303:
- [this](size_t a, size_t b) { return data[a] < data[b]; });
+ [this](size_t a, size_t b) { return data[a] < data[b]; });
+ }| limit = 0; | ||
| } | ||
| // std::partial_sort need limit << s can get performance benefit | ||
| if (limit > (s / 8.0)) limit = 0; |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| if (limit > (s / 8.0)) limit = 0; | |
| if (limit > (s / 8.0)) { limit = 0; | |
| } |
|
|
||
| if (limit >= s) limit = 0; | ||
| // std::partial_sort need limit << s can get performance benefit | ||
| if (limit > (s / 8.0)) limit = 0; |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| if (limit > (s / 8.0)) limit = 0; | |
| if (limit > (s / 8.0)) { limit = 0; | |
| } |
|
run buildall |
|
TeamCity be ut coverage result: |
apache#39089)" This reverts commit 564d3cd.
3 participants
Proposed changes
Issue Number: cherry pick #38985