[Performance](opt) opt the order by performance in permutation #39092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #pragma once | ||
|
|
||
| #include <glog/logging.h> |
Contributor
There was a problem hiding this comment.
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
#include <glog/logging.h>
^| std::partial_sort(res.begin(), sort_end, res.end(), | ||
| [this](size_t a, size_t b) { return data[a] < data[b]; }); | ||
| } else { | ||
| if (reverse) |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (reverse) | |
| if (reverse) { |
be/src/vec/columns/column_decimal.h:309:
- else
+ } else| if (reverse) | ||
| pdqsort(res.begin(), res.end(), | ||
| [this](size_t a, size_t b) { return data[a] > data[b]; }); | ||
| else |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| else | |
| else { |
be/src/vec/columns/column_decimal.h:311:
- [this](size_t a, size_t b) { return data[a] < data[b]; });
+ [this](size_t a, size_t b) { return data[a] < data[b]; });
+ }| limit = 0; | ||
| } | ||
| // std::partial_sort need limit << s can get performance benefit | ||
| if (limit > (s / 8.0)) limit = 0; |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (limit > (s / 8.0)) limit = 0; | |
| if (limit > (s / 8.0)) { limit = 0; | |
| } |
|
|
||
| if (limit >= s) limit = 0; | ||
| // std::partial_sort need limit << s can get performance benefit | ||
| if (limit > (s / 8.0)) limit = 0; |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (limit > (s / 8.0)) limit = 0; | |
| if (limit > (s / 8.0)) { limit = 0; | |
| } |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 50159 ms |
TPC-DS: Total hot run time: 203556 ms |
ClickBench: Total hot run time: 31.31 s |
|
TeamCity be ut coverage result: |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Aug 27, 2024
…e#39092) Issue Number: cherry pick apache#38985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: cherry pick #38985