Skip to content

[fix](variable) support all type functions #39144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Aug 12, 2024
Merged

[fix](variable) support all type functions #39144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ public void setUserVar(SetVar setVar) {
} else if (literalExpr instanceof NullLiteral) {
return Literal.of(null);
} else {
return Literal.of("");
return Literal.of(literalExpr.getStringValue());
}
} else {
// If there are no such user defined var, just return the NULL value.
Expand Down Expand Up @@ -587,7 +587,7 @@ public void fillValueForUserDefinedVar(VariableExpr desc) {
desc.setIsNull();
} else {
desc.setType(Type.VARCHAR);
desc.setStringValue("");
desc.setStringValue(literalExpr.getStringValue());
}
} else {
// If there are no such user defined var, just fill the NULL value.
Expand Down
3 changes: 3 additions & 0 deletions regression-test/data/nereids_p0/test_user_var.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,6 @@ true false
-- !function --
4

-- !datetime --
2007-12-01 00:30:19

2 changes: 2 additions & 0 deletions regression-test/suites/nereids_p0/test_user_var.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ suite("test_user_var") {
sql "SET @c1='H', @c2=''"
sql "SET @d1=true, @d2=false"
sql "SET @f1=null"
sql "set @dt1 = from_unixtime(1196440219);"
sql "set @func_1=(abs(1) + 1) * 2"
sql "set disable_nereids_rules=PRUNE_EMPTY_PARTITION"

Expand All @@ -33,6 +34,7 @@ suite("test_user_var") {
qt_boolean 'select @d1, @d2;'
qt_null_literal 'select @f1, @f2;'
qt_function 'select @func_1'
qt_datetime 'select @dt1'

multi_sql(
"""
Expand Down