Skip to content

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Aug 10, 2024

pick (#37288)

When using routine load, After the data load is completed, the lag is still a positive number:

  Lag: {"0":16,"1":15,"2":16,"3":16,"4":16,"5":16,"6":15,"7":16,"8":16,"9":16,"10":15,"11":16,"12":15,"13":15,"14":16,"15":16,"16":17,"17":15,"18":16,"19":15,"20":16,"21":16,"22":16,"23":16,"24":15,"25":17,"26":17,"27":16,"28":16,"29":16,"30":16,"31":17,"32":14,"33":16,"34":17,"35":16,"36":15,"37":15,"38":15,"39":16,"40":16,"41":16,"42":15,"43":15,"44":17,"45":16,"46":15,"47":15,"48":16,"49":17,"50":16,"51":15,"52":16,"53":15,"54":15,"55":17,"56":16,"57":17,"58":16,"59":16,"60":15,"61":15,"62":16,"63":16,"64":17,"65":16,"66":15,"67":16,"68":17,"69":16,"70":15,"71":17}

and the routing load is paused when the Kafka data reaches TTL and is deleted, the error is out of range.

The reason why this happened is EOF has it offset which needed statistics.

note(important):
After the bug is fixed, if you set

"property.enable.partition.eof" = "false"

in your routine load job, it will meet the problem. For EOF has offset, and the config is true in Doris default.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@sollhui
Copy link
Contributor Author

sollhui commented Aug 10, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

…ter TTL (#37288)

    When using routine load, After the data load is completed, the lag is
    still a positive number:
    ```
      Lag: {"0":16,"1":15,"2":16,"3":16,"4":16,"5":16,"6":15,"7":16,"8":16,"9":16,"10":15,"11":16,"12":15,"13":15,"14":16,"15":16,"16":17,"17":15,"18":16,"19":15,"20":16,"21":16,"22":16,"23":16,"24":15,"25":17,"26":17,"27":16,"28":16,"29":16,"30":16,"31":17,"32":14,"33":16,"34":17,"35":16,"36":15,"37":15,"38":15,"39":16,"40":16,"41":16,"42":15,"43":15,"44":17,"45":16,"46":15,"47":15,"48":16,"49":17,"50":16,"51":15,"52":16,"53":15,"54":15,"55":17,"56":16,"57":17,"58":16,"59":16,"60":15,"61":15,"62":16,"63":16,"64":17,"65":16,"66":15,"67":16,"68":17,"69":16,"70":15,"71":17}
    ```
    and the routing load is paused when the Kafka data reaches TTL and is
    deleted, the error is `out of range`.

    The reason why this happened is EOF has it offset which needed
    statistics.

    **note(important):**
    After the bug is fixed, if you set
    ```
    "property.enable.partition.eof" = "false"
    ```
    in your routine load job, it will meet the problem. For EOF has offset,
    and the config is true in Doris default.
@sollhui
Copy link
Contributor Author

sollhui commented Aug 10, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.72% (8103/21482)
Line Coverage: 29.35% (66392/226196)
Region Coverage: 28.85% (34242/118704)
Branch Coverage: 24.73% (17601/71170)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b33dd8e6fdb6c3556e9fbfc6a74ce2b1d1ae9fb6_b33dd8e6fdb6c3556e9fbfc6a74ce2b1d1ae9fb6/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 49793 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b33dd8e6fdb6c3556e9fbfc6a74ce2b1d1ae9fb6, data reload: false

------ Round 1 ----------------------------------
q1	17951	4451	4357	4357
q2	2036	157	147	147
q3	10448	1902	1949	1902
q4	10322	1230	1316	1230
q5	8505	3895	3912	3895
q6	228	127	128	127
q7	2035	1613	1594	1594
q8	9284	2717	2697	2697
q9	10686	10381	10185	10185
q10	8650	3509	3504	3504
q11	419	248	257	248
q12	469	304	302	302
q13	18349	3920	3989	3920
q14	370	324	321	321
q15	515	465	465	465
q16	677	579	569	569
q17	1120	975	987	975
q18	7299	7026	6907	6907
q19	1825	1650	1615	1615
q20	532	331	297	297
q21	4460	4100	4084	4084
q22	543	452	452	452
Total cold run time: 116723 ms
Total hot run time: 49793 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4345	4318	4314	4314
q2	321	222	224	222
q3	4155	4129	4129	4129
q4	2741	2765	2744	2744
q5	7205	7111	7111	7111
q6	245	121	121	121
q7	3286	2817	2842	2817
q8	4424	4529	4449	4449
q9	16883	16882	16747	16747
q10	4262	4276	4245	4245
q11	780	673	695	673
q12	1024	864	862	862
q13	7437	3682	3744	3682
q14	446	422	427	422
q15	494	466	460	460
q16	732	686	682	682
q17	3819	3865	3843	3843
q18	8708	8813	8773	8773
q19	1716	1703	1649	1649
q20	2374	2132	2091	2091
q21	8539	8444	8509	8444
q22	1054	1006	1021	1006
Total cold run time: 84990 ms
Total hot run time: 79486 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 203294 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b33dd8e6fdb6c3556e9fbfc6a74ce2b1d1ae9fb6, data reload: false

query1	957	390	403	390
query2	6524	2866	2873	2866
query3	6923	207	202	202
query4	21464	17954	17948	17948
query5	19743	6527	6550	6527
query6	313	221	234	221
query7	4328	301	312	301
query8	406	408	428	408
query9	3125	2701	2640	2640
query10	402	296	294	294
query11	11299	10653	10610	10610
query12	124	76	77	76
query13	5610	696	690	690
query14	17912	13233	13349	13233
query15	364	243	247	243
query16	6451	280	266	266
query17	1695	1434	871	871
query18	2338	413	413	413
query19	206	148	154	148
query20	81	79	79	79
query21	191	96	104	96
query22	5233	4962	5044	4962
query23	32508	32094	31911	31911
query24	6806	6520	6543	6520
query25	529	438	408	408
query26	528	165	162	162
query27	1878	293	293	293
query28	6192	2392	2359	2359
query29	2895	2720	2720	2720
query30	247	170	170	170
query31	932	746	731	731
query32	69	65	65	65
query33	395	253	244	244
query34	837	483	481	481
query35	1115	888	959	888
query36	1292	1182	1223	1182
query37	90	59	67	59
query38	3100	2929	2906	2906
query39	1378	1319	1340	1319
query40	207	97	92	92
query41	46	44	52	44
query42	82	81	81	81
query43	793	769	691	691
query44	1123	725	719	719
query45	244	242	227	227
query46	1224	967	989	967
query47	1883	1617	1711	1617
query48	1025	714	705	705
query49	619	381	387	381
query50	877	589	610	589
query51	4772	4645	4673	4645
query52	91	75	83	75
query53	446	325	335	325
query54	2636	2468	2475	2468
query55	92	81	90	81
query56	216	240	200	200
query57	1196	1108	1078	1078
query58	221	208	203	203
query59	4239	3794	4043	3794
query60	218	197	206	197
query61	100	97	98	97
query62	767	526	448	448
query63	482	356	347	347
query64	2571	1537	1481	1481
query65	3651	3560	3562	3560
query66	812	379	380	379
query67	15957	15244	15799	15244
query68	9331	633	645	633
query69	583	353	346	346
query70	1705	1474	1581	1474
query71	417	300	303	300
query72	6594	3504	3476	3476
query73	737	314	326	314
query74	6292	5844	5874	5844
query75	5363	3749	3638	3638
query76	5805	1145	1208	1145
query77	988	267	260	260
query78	12669	11602	11524	11524
query79	9869	635	645	635
query80	1478	398	408	398
query81	493	233	230	230
query82	1586	100	104	100
query83	169	133	129	129
query84	263	70	70	70
query85	885	333	328	328
query86	335	306	286	286
query87	3221	3015	3043	3015
query88	4914	2292	2293	2292
query89	487	289	299	289
query90	1959	209	208	208
query91	187	144	139	139
query92	54	56	52	52
query93	6879	581	569	569
query94	716	210	210	210
query95	1123	1082	1040	1040
query96	642	321	334	321
query97	6527	6370	6420	6370
query98	185	170	171	170
query99	2975	852	1003	852
Total cold run time: 318501 ms
Total hot run time: 203294 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.29 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b33dd8e6fdb6c3556e9fbfc6a74ce2b1d1ae9fb6, data reload: false

query1	0.02	0.03	0.03
query2	0.07	0.03	0.02
query3	0.25	0.05	0.04
query4	1.80	0.06	0.07
query5	0.54	0.53	0.52
query6	1.29	0.62	0.62
query7	0.02	0.01	0.01
query8	0.03	0.03	0.02
query9	0.54	0.48	0.48
query10	0.53	0.54	0.52
query11	0.12	0.09	0.09
query12	0.11	0.09	0.09
query13	0.61	0.61	0.60
query14	0.78	0.81	0.78
query15	0.77	0.76	0.75
query16	0.39	0.37	0.38
query17	1.03	1.01	0.99
query18	0.21	0.27	0.24
query19	1.96	1.87	1.86
query20	0.02	0.01	0.01
query21	15.45	0.55	0.54
query22	2.40	2.63	1.56
query23	17.06	1.08	0.92
query24	5.31	0.62	1.11
query25	0.36	0.05	0.06
query26	0.62	0.16	0.16
query27	0.05	0.04	0.04
query28	8.10	0.74	0.76
query29	12.78	2.23	2.29
query30	0.64	0.53	0.53
query31	2.81	0.39	0.37
query32	3.36	0.50	0.51
query33	3.10	3.09	3.05
query34	15.25	4.79	4.79
query35	4.87	4.83	4.84
query36	1.07	1.02	1.02
query37	0.06	0.05	0.04
query38	0.04	0.03	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.15
query41	0.06	0.01	0.02
query42	0.03	0.01	0.02
query43	0.03	0.02	0.01
Total cold run time: 104.72 s
Total hot run time: 30.29 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit b33dd8e6fdb6c3556e9fbfc6a74ce2b1d1ae9fb6 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 11, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit e19f603 into apache:branch-2.0 Aug 11, 2024
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Aug 27, 2024
…ter TTL(apache#37288) (apache#39183)

pick (apache#37288)

When using routine load, After the data load is completed, the lag is
still a positive number:
```
  Lag: {"0":16,"1":15,"2":16,"3":16,"4":16,"5":16,"6":15,"7":16,"8":16,"9":16,"10":15,"11":16,"12":15,"13":15,"14":16,"15":16,"16":17,"17":15,"18":16,"19":15,"20":16,"21":16,"22":16,"23":16,"24":15,"25":17,"26":17,"27":16,"28":16,"29":16,"30":16,"31":17,"32":14,"33":16,"34":17,"35":16,"36":15,"37":15,"38":15,"39":16,"40":16,"41":16,"42":15,"43":15,"44":17,"45":16,"46":15,"47":15,"48":16,"49":17,"50":16,"51":15,"52":16,"53":15,"54":15,"55":17,"56":16,"57":17,"58":16,"59":16,"60":15,"61":15,"62":16,"63":16,"64":17,"65":16,"66":15,"67":16,"68":17,"69":16,"70":15,"71":17}
```
and the routing load is paused when the Kafka data reaches TTL and is
deleted, the error is `out of range`.

The reason why this happened is EOF has it offset which needed
statistics.

**note(important):**
After the bug is fixed, if you set
```
"property.enable.partition.eof" = "false"
```
in your routine load job, it will meet the problem. For EOF has offset,
and the config is true in Doris default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants