Skip to content

[enhancement](metric) Support user connection metric #39200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Aug 21, 2024
Merged

[enhancement](metric) Support user connection metric #39200

morningman merged 1 commit into from
Aug 21, 2024

Conversation

@stalary
Copy link
Contributor

@stalary stalary commented Aug 11, 2024

Proposed changes

Issue Number: close #xxx

Support user connection metric, it is required in multi-tenant scenarios.

@doris-robot
Copy link

doris-robot commented Aug 11, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the doing label Aug 11, 2024
@stalary stalary changed the title [enhancement][metric] Support user connection metric [enhancement](metric) Support user connection metric Aug 11, 2024
@stalary stalary force-pushed the feature-user_connection_metric branch from 8c7bd3b to 0fce0f2 Compare August 11, 2024 14:32
morningman
morningman approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this Aug 11, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2024

PR approved by anyone and no changes requested.

@stalary
Copy link
Contributor Author

stalary commented Aug 11, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Aug 12, 2024

TPC-H: Total hot run time: 39805 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0fce0f2713db0f9be7562fe5d0e8e25a20ba3493, data reload: false

------ Round 1 ----------------------------------
q1	18544	4445	4300	4300
q2	2019	176	180	176
q3	10494	1205	1036	1036
q4	11541	772	736	736
q5	7593	2530	2515	2515
q6	221	138	136	136
q7	975	592	590	590
q8	9213	1927	1893	1893
q9	8925	6636	6602	6602
q10	7138	2259	2215	2215
q11	473	253	246	246
q12	396	230	233	230
q13	18734	3225	3166	3166
q14	289	241	255	241
q15	542	486	507	486
q16	1381	425	427	425
q17	1545	687	723	687
q18	9214	7425	7640	7425
q19	5251	1104	1128	1104
q20	683	346	345	345
q21	5418	4528	4240	4240
q22	1115	1011	1017	1011
Total cold run time: 121704 ms
Total hot run time: 39805 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4556	4289	4249	4249
q2	368	282	275	275
q3	2966	2819	2708	2708
q4	1999	1699	1698	1698
q5	5451	5450	5528	5450
q6	229	137	143	137
q7	2178	1739	1769	1739
q8	3311	3463	3433	3433
q9	8801	8925	8835	8835
q10	3424	3197	3269	3197
q11	632	499	510	499
q12	818	642	634	634
q13	17107	3181	3160	3160
q14	326	304	303	303
q15	549	483	494	483
q16	509	430	434	430
q17	1849	1533	1504	1504
q18	8092	7843	7920	7843
q19	1727	1546	1578	1546
q20	2389	1884	1854	1854
q21	9389	5099	5245	5099
q22	1112	998	1016	998
Total cold run time: 77782 ms
Total hot run time: 56074 ms

@doris-robot
Copy link

doris-robot commented Aug 12, 2024

TPC-DS: Total hot run time: 202487 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0fce0f2713db0f9be7562fe5d0e8e25a20ba3493, data reload: false

query1	917	377	364	364
query2	6346	1982	1910	1910
query3	6635	207	220	207
query4	31448	23337	23161	23161
query5	3518	492	505	492
query6	263	166	162	162
query7	4571	297	288	288
query8	246	207	199	199
query9	8552	2386	2356	2356
query10	529	465	476	465
query11	17710	14952	15052	14952
query12	139	102	97	97
query13	1640	373	370	370
query14	10082	7766	7694	7694
query15	266	214	234	214
query16	7714	531	471	471
query17	1713	604	578	578
query18	1950	293	308	293
query19	196	158	150	150
query20	125	121	113	113
query21	212	108	114	108
query22	4649	4433	4594	4433
query23	34366	33545	33714	33545
query24	10834	2662	2693	2662
query25	619	405	413	405
query26	706	151	156	151
query27	2148	280	285	280
query28	5952	1981	1974	1974
query29	805	434	425	425
query30	259	149	151	149
query31	951	759	730	730
query32	96	57	56	56
query33	663	317	289	289
query34	872	537	468	468
query35	996	809	823	809
query36	1098	944	947	944
query37	138	82	81	81
query38	4254	4230	4133	4133
query39	1428	1383	1534	1383
query40	213	115	120	115
query41	49	47	42	42
query42	125	93	95	93
query43	524	467	483	467
query44	1111	733	744	733
query45	234	199	198	198
query46	1091	709	732	709
query47	1845	1765	1754	1754
query48	367	304	303	303
query49	847	417	430	417
query50	806	399	400	399
query51	6812	6632	6559	6559
query52	101	97	89	89
query53	249	181	183	181
query54	884	453	462	453
query55	75	73	79	73
query56	275	257	247	247
query57	1147	1084	1079	1079
query58	224	230	226	226
query59	2954	2694	2811	2694
query60	292	257	270	257
query61	96	113	95	95
query62	782	650	621	621
query63	218	178	175	175
query64	9358	2256	1783	1783
query65	3215	3132	3137	3132
query66	734	323	332	323
query67	15555	14729	14726	14726
query68	7912	553	555	553
query69	468	429	431	429
query70	1212	1116	1122	1116
query71	529	269	268	268
query72	20091	17082	16941	16941
query73	847	326	325	325
query74	9336	8845	8827	8827
query75	4543	2682	2708	2682
query76	4465	1020	968	968
query77	781	316	319	316
query78	10645	8950	9379	8950
query79	8789	520	526	520
query80	2313	498	498	498
query81	602	224	218	218
query82	757	142	184	142
query83	301	149	146	146
query84	279	75	81	75
query85	1271	289	276	276
query86	409	287	269	269
query87	4741	4480	4479	4479
query88	5142	2504	2524	2504
query89	504	288	281	281
query90	2030	196	200	196
query91	120	97	93	93
query92	59	49	51	49
query93	6699	528	529	528
query94	846	294	279	279
query95	361	265	260	260
query96	622	282	276	276
query97	3185	3053	3062	3053
query98	235	205	203	203
query99	1540	1263	1332	1263
Total cold run time: 327423 ms
Total hot run time: 202487 ms

@doris-robot
Copy link

doris-robot commented Aug 12, 2024

ClickBench: Total hot run time: 30.21 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0fce0f2713db0f9be7562fe5d0e8e25a20ba3493, data reload: false

query1	0.05	0.05	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.06
query4	1.67	0.07	0.07
query5	0.48	0.48	0.49
query6	1.13	0.72	0.72
query7	0.01	0.01	0.02
query8	0.05	0.04	0.04
query9	0.55	0.50	0.49
query10	0.54	0.52	0.54
query11	0.16	0.12	0.11
query12	0.14	0.12	0.13
query13	0.60	0.60	0.58
query14	0.76	0.79	0.77
query15	0.85	0.82	0.82
query16	0.37	0.38	0.35
query17	0.93	0.99	1.07
query18	0.23	0.22	0.22
query19	1.83	1.76	1.81
query20	0.01	0.00	0.01
query21	15.39	0.73	0.66
query22	4.61	7.74	1.41
query23	18.16	1.33	1.24
query24	2.05	0.22	0.21
query25	0.15	0.07	0.09
query26	0.30	0.22	0.22
query27	0.46	0.22	0.23
query28	13.38	1.01	0.99
query29	12.60	3.42	3.43
query30	0.24	0.05	0.05
query31	2.89	0.38	0.40
query32	3.29	0.47	0.47
query33	2.89	2.90	2.93
query34	17.04	4.31	4.39
query35	4.46	4.43	4.44
query36	0.65	0.46	0.48
query37	0.20	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.12	0.12
query41	0.09	0.05	0.04
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.98 s
Total hot run time: 30.21 s

@stalary stalary removed the doing label Aug 13, 2024
dataroaring
dataroaring approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit f8ef8c1 into apache:master Aug 21, 2024
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@stalary @dataroaring
[enhancement](metric) Support user connection metric (#39200)
e2a725d 
Support user connection metric, it is required in multi-tenant
scenarios.
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stalary @doris-robot @morningman @dataroaring