[Fix](JsonReader) Return correct status when parse failed #39206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
eldenmoon
force-pushed
the
json-load-type
branch
from
1bdfe13 to
e94357a
Compare
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 38868 ms |
TPC-DS: Total hot run time: 201990 ms |
ClickBench: Total hot run time: 30.63 s |
When using `JsonFunctions::extract_from_object`, but input obj is not object type but other types like null, then Status
should be `simdjson::INCORRECT_TYPE` to fill the default value in the later process`.Example, json path is `$.city.name`, but input json is `{"city" : null}` then `Status::NotFound` should be returned, in the following, column will be filled with default values.
eldenmoon
force-pushed
the
json-load-type
branch
from
e94357a to
2726420
Compare
Member
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39832 ms |
TPC-DS: Total hot run time: 202288 ms |
ClickBench: Total hot run time: 30.38 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 13, 2024
When using `JsonFunctions::extract_from_object`, but input obj is not
object type but other types like null, then Status should be
`simdjson::INCORRECT_TYPE` to fill the default value in the later
process. Example, json path is `$.city.name`, but input json is `{"city"
: null}` then `Status::NotFound` should be returned, in the following,
column will be filled with default values.
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 13, 2024
When using `JsonFunctions::extract_from_object`, but input obj is not
object type but other types like null, then Status should be
`simdjson::INCORRECT_TYPE` to fill the default value in the later
process. Example, json path is `$.city.name`, but input json is `{"city"
: null}` then `Status::NotFound` should be returned, in the following,
column will be filled with default values.
yiguolei
pushed a commit
that referenced
this pull request
Aug 13, 2024
eldenmoon
added a commit
that referenced
this pull request
Aug 14, 2024
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
When using `JsonFunctions::extract_from_object`, but input obj is not
object type but other types like null, then Status should be
`simdjson::INCORRECT_TYPE` to fill the default value in the later
process. Example, json path is `$.city.name`, but input json is `{"city"
: null}` then `Status::NotFound` should be returned, in the following,
column will be filled with default values.
dataroaring
pushed a commit
that referenced
this pull request
Aug 17, 2024
When using `JsonFunctions::extract_from_object`, but input obj is not
object type but other types like null, then Status should be
`simdjson::INCORRECT_TYPE` to fill the default value in the later
process. Example, json path is `$.city.name`, but input json is `{"city"
: null}` then `Status::NotFound` should be returned, in the following,
column will be filled with default values.
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
JsonFunctions::extract_from_object, but input obj is not object type but other types like null, then Status should besimdjson::INCORRECT_TYPEto fill the default value in the later process. Example, json path is$.city.name, but input json is{"city" : null}thenStatus::NotFoundshould be returned, in the following, column will be filled with default values.Proposed changes
Issue Number: close #xxx