Skip to content

Conversation

@csun5285
Copy link
Contributor

Proposed changes

pick from #38989

fix

fix

remove unused code

fix p0
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@csun5285
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.52% (9316/25510)
Line Coverage: 28.01% (76323/272495)
Region Coverage: 26.81% (39199/146205)
Branch Coverage: 23.53% (19897/84546)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4595b63db4cc795038a19185204aa4784b2a04d1_4595b63db4cc795038a19185204aa4784b2a04d1/report/index.html

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 13, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@airborne12 airborne12 merged commit 60eeec3 into apache:branch-2.1 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. meta-change reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants