Skip to content

[fix](nereids) fix partitionTopN choosing under multi winexprs #39233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Aug 13, 2024
Merged

[fix](nereids) fix partitionTopN choosing under multi winexprs #39233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalWindow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,8 @@ && child(0).child(0) instanceof LogicalPartitionTopN)) {
if (curPartitionLimit < chosenRowNumberPartitionLimit) {
chosenRowNumberPartitionLimit = curPartitionLimit;
chosenWindowFunc = windowFunc;
hasRowNumber = true;
}
hasRowNumber = true;
} else if (!hasRowNumber) {
// if no row_number, choose the one with minimal limit value
if (curPartitionLimit < chosenPartitionLimit) {
Expand Down
14 changes: 14 additions & 0 deletions ...ids_rules_p0/push_down_filter_through_window/push_down_multi_filter_through_window.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,20 @@ suite("push_down_multi_filter_through_window") {
contains "partition limit: 10"
}

explain {
sql ("select * from (select rank() over(partition by c1 order by c3) as rk, row_number() over(partition by c1, c2 order by c3) as rn from push_down_multi_predicate_through_window_t) t where rk <= 1;")
contains "VPartitionTopN"
contains "functions: rank"
contains "partition limit: 1"
}

explain {
sql ("select * from (select rank() over(partition by c1 order by c3) as rk, row_number() over(partition by c1, c2 order by c3) as rn from push_down_multi_predicate_through_window_t) t where rn <= 10;")
contains "VPartitionTopN"
contains "functions: row_number"
contains "partition limit: 10"
}

explain {
sql ("select * from (select rank() over(partition by c1 order by c3) as rk, rank() over(partition by c1, c2 order by c3) as rn from push_down_multi_predicate_through_window_t) t where rn <= 1 and rk <= 10;")
contains "VPartitionTopN"
Expand Down