Skip to content

revert [improvement](mv) Support to use cast when create sync materialized view #38008 #39378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Aug 15, 2024
Merged

revert [improvement](mv) Support to use cast when create sync materialized view #38008 #39378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,8 @@ public void analyzeSelectClause(Analyzer analyzer) throws AnalysisException {

Expr selectListItemExpr = selectListItem.getExpr();
selectListItemExpr.setDisableTableName(true);
Expr realItem = selectListItemExpr.unwrapExpr(false);
if (!(realItem instanceof SlotRef) && !(realItem instanceof FunctionCallExpr)
&& !(realItem instanceof ArithmeticExpr)) {
if (!(selectListItemExpr instanceof SlotRef) && !(selectListItemExpr instanceof FunctionCallExpr)
&& !(selectListItemExpr instanceof ArithmeticExpr)) {
throw new AnalysisException("The materialized view only support the single column or function expr. "
+ "Error column: " + selectListItemExpr.toSql());
}
Expand Down
11 changes: 0 additions & 11 deletions regression-test/data/mv_p0/contain_cast/mv_contains_cast.out
View file
Open in desktop

This file was deleted.

130 changes: 0 additions & 130 deletions regression-test/suites/mv_p0/contain_cast/mv_contains_cast.groovy
View file
Open in desktop

This file was deleted.