Skip to content

Conversation

@zclllyybb
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

before:

mysql> delete from table_7298276 where  中文列名1 > '2023-08-17' and 中文列名2 > '-68' and 中文列名3 in ("77", "0", "-35", "-8", "93", "-87", "42", "24", "57", "74");
ERROR 1105 (HY000): errCode = 2, detailMessage = delete job failed, errmsg:10019: [(10.16.10.8)[INVALID_ARGUMENT]failed to parse condition_str, condtion=TCondition {
  01: column_name (string) = "\xe4\xb8\xad\xe6\x96\x87\xe5\x88\x97\xe5\x90\x8d1",
  02: condition_op (string) = ">",
  03: condition_values (list) = list<string>[1] {
    [0] = "2023-08-17",
  },
  04: column_unique_id (i32) = 0,
  05: marked_by_runtime_filter (bool) = false,
  1000: compound_type (i32) = 0,
}]

now:

mysql> delete from table_7298276 where 中文列名1 > '2012-08-17' and 中文列名2 > -68 and 中文列名3 in (1,2,3);
Query OK, 0 rows affected (0.14 sec)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the doing label Aug 14, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 37981 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ec999eb2c6298b93b96ea5097e410954be080844, data reload: false

------ Round 1 ----------------------------------
q1	18162	4508	4349	4349
q2	2435	181	182	181
q3	11130	1169	1120	1120
q4	10495	733	796	733
q5	7756	2845	2810	2810
q6	226	146	144	144
q7	974	607	606	606
q8	9536	2033	2030	2030
q9	7282	6569	6543	6543
q10	7048	2194	2231	2194
q11	467	246	239	239
q12	385	224	222	222
q13	17772	2992	3048	2992
q14	286	237	231	231
q15	531	476	477	476
q16	513	391	391	391
q17	963	626	704	626
q18	7440	6855	6812	6812
q19	7153	1112	1062	1062
q20	686	330	336	330
q21	3829	2994	2916	2916
q22	1133	1039	974	974
Total cold run time: 116202 ms
Total hot run time: 37981 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4447	4238	4263	4238
q2	376	279	269	269
q3	2822	2579	2615	2579
q4	1940	1612	1582	1582
q5	5365	5381	5349	5349
q6	220	131	130	130
q7	2088	1657	1683	1657
q8	3159	3320	3324	3320
q9	8340	8309	8340	8309
q10	3399	3145	3148	3145
q11	595	491	507	491
q12	802	592	596	592
q13	16298	3008	2978	2978
q14	311	270	278	270
q15	522	497	485	485
q16	466	425	433	425
q17	1790	1479	1482	1479
q18	7798	7393	7475	7393
q19	1670	1636	1533	1533
q20	2016	1847	1797	1797
q21	5268	5215	5088	5088
q22	1139	1019	1015	1015
Total cold run time: 70831 ms
Total hot run time: 54124 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184550 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ec999eb2c6298b93b96ea5097e410954be080844, data reload: false

query1	920	373	368	368
query2	6460	2080	2025	2025
query3	6643	210	218	210
query4	28247	23305	23090	23090
query5	4237	487	489	487
query6	274	177	175	175
query7	4594	286	289	286
query8	245	200	192	192
query9	8490	2468	2435	2435
query10	436	280	283	280
query11	15518	15054	14978	14978
query12	142	105	96	96
query13	1621	360	348	348
query14	9428	6500	7009	6500
query15	223	167	169	167
query16	7397	468	492	468
query17	1153	560	552	552
query18	1922	278	284	278
query19	192	141	138	138
query20	111	106	104	104
query21	213	98	99	98
query22	4311	4120	4001	4001
query23	33879	33219	33531	33219
query24	12400	2807	2859	2807
query25	649	368	379	368
query26	1765	156	150	150
query27	2865	273	268	268
query28	7744	2043	2031	2031
query29	1073	432	442	432
query30	306	145	155	145
query31	941	757	765	757
query32	99	52	53	52
query33	752	279	271	271
query34	977	456	463	456
query35	821	716	731	716
query36	1077	912	961	912
query37	261	85	80	80
query38	3966	4021	3769	3769
query39	1418	1398	1375	1375
query40	264	114	113	113
query41	46	45	44	44
query42	118	93	95	93
query43	538	474	477	474
query44	1244	733	744	733
query45	202	164	166	164
query46	1102	720	743	720
query47	1870	1810	1813	1810
query48	364	290	303	290
query49	1214	409	418	409
query50	792	401	406	401
query51	6849	6718	6668	6668
query52	105	92	88	88
query53	256	182	180	180
query54	978	446	447	446
query55	81	72	77	72
query56	250	236	252	236
query57	1176	1047	1068	1047
query58	240	220	234	220
query59	3181	2786	2848	2786
query60	292	266	261	261
query61	101	95	97	95
query62	824	600	665	600
query63	216	183	195	183
query64	6385	2256	1714	1714
query65	3185	3171	3159	3159
query66	1401	338	334	334
query67	15380	14977	14869	14869
query68	4605	541	540	540
query69	402	272	270	270
query70	1133	1033	1115	1033
query71	416	274	276	274
query72	6408	2255	2025	2025
query73	801	317	316	316
query74	9122	8874	8802	8802
query75	3431	2680	2691	2680
query76	2597	980	1022	980
query77	444	311	310	310
query78	10726	9380	8940	8940
query79	3616	522	521	521
query80	1743	478	493	478
query81	570	224	228	224
query82	1171	141	139	139
query83	309	146	145	145
query84	273	79	78	78
query85	920	281	293	281
query86	463	292	294	292
query87	4449	4191	4149	4149
query88	4565	2313	2314	2313
query89	437	291	292	291
query90	1896	195	188	188
query91	119	97	98	97
query92	64	53	48	48
query93	4443	538	530	530
query94	905	286	291	286
query95	353	260	253	253
query96	593	266	269	266
query97	3229	3096	3049	3049
query98	225	206	206	206
query99	1767	1260	1253	1253
Total cold run time: 294619 ms
Total hot run time: 184550 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.07 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ec999eb2c6298b93b96ea5097e410954be080844, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.22	0.05	0.04
query4	1.68	0.07	0.07
query5	0.50	0.47	0.49
query6	1.13	0.75	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.56	0.49	0.49
query10	0.53	0.54	0.54
query11	0.15	0.12	0.12
query12	0.16	0.13	0.12
query13	0.60	0.60	0.60
query14	0.77	0.78	0.77
query15	0.91	0.82	0.82
query16	0.37	0.37	0.37
query17	1.03	0.95	1.00
query18	0.23	0.21	0.23
query19	1.83	1.73	1.75
query20	0.01	0.01	0.01
query21	15.39	0.76	0.65
query22	4.33	6.44	2.15
query23	18.33	1.40	1.30
query24	2.07	0.22	0.20
query25	0.14	0.08	0.07
query26	0.29	0.22	0.22
query27	0.46	0.23	0.23
query28	13.40	1.00	1.00
query29	12.65	3.33	3.33
query30	0.23	0.05	0.05
query31	2.89	0.41	0.39
query32	3.27	0.49	0.48
query33	2.93	2.99	2.97
query34	16.99	4.46	4.40
query35	4.46	4.42	4.47
query36	0.64	0.47	0.48
query37	0.19	0.16	0.16
query38	0.15	0.14	0.15
query39	0.05	0.04	0.04
query40	0.14	0.12	0.12
query41	0.10	0.04	0.05
query42	0.06	0.05	0.04
query43	0.05	0.04	0.05
Total cold run time: 110.09 s
Total hot run time: 31.07 s

@zclllyybb
Copy link
Contributor Author

run compile

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 37931 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 53ce3e3e3f7abec9d61d8df0f44d048a9af05df2, data reload: false

------ Round 1 ----------------------------------
q1	17888	4372	4298	4298
q2	2056	210	213	210
q3	11775	1056	1109	1056
q4	10530	752	720	720
q5	7815	2835	2863	2835
q6	262	156	157	156
q7	1012	645	659	645
q8	9611	2046	2104	2046
q9	8675	6568	6588	6568
q10	7075	2216	2228	2216
q11	474	272	259	259
q12	411	244	239	239
q13	18730	3006	3015	3006
q14	284	243	255	243
q15	565	521	519	519
q16	511	403	406	403
q17	970	686	699	686
q18	7341	6725	6696	6696
q19	6655	1066	1059	1059
q20	674	346	359	346
q21	3940	2692	2736	2692
q22	1121	1047	1033	1033
Total cold run time: 118375 ms
Total hot run time: 37931 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4476	4286	4291	4286
q2	401	305	305	305
q3	2831	2637	2696	2637
q4	1973	1697	1756	1697
q5	5705	5704	5649	5649
q6	244	152	146	146
q7	2144	1806	1770	1770
q8	3314	3530	3426	3426
q9	8816	8741	8735	8735
q10	3574	3324	3335	3324
q11	625	540	549	540
q12	846	665	684	665
q13	16959	3228	3113	3113
q14	322	296	286	286
q15	546	526	515	515
q16	525	476	463	463
q17	1824	1580	1548	1548
q18	8263	8163	7780	7780
q19	8392	1586	1586	1586
q20	2128	1906	1888	1888
q21	13913	5213	5404	5213
q22	1170	1091	1102	1091
Total cold run time: 88991 ms
Total hot run time: 56663 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196254 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 53ce3e3e3f7abec9d61d8df0f44d048a9af05df2, data reload: false

query1	1322	932	897	897
query2	6624	1999	2051	1999
query3	10646	3917	3625	3625
query4	58300	24260	23548	23548
query5	5983	648	667	648
query6	540	181	187	181
query7	6473	319	316	316
query8	452	360	364	360
query9	9167	2517	2482	2482
query10	547	314	319	314
query11	17865	15079	15272	15079
query12	192	131	125	125
query13	1657	418	426	418
query14	12101	7253	7233	7233
query15	245	203	199	199
query16	7694	529	513	513
query17	1193	617	608	608
query18	1860	356	369	356
query19	307	180	173	173
query20	158	135	142	135
query21	262	147	142	142
query22	4474	4522	4209	4209
query23	34237	33726	33932	33726
query24	5786	3103	2980	2980
query25	577	434	436	434
query26	728	187	187	187
query27	1826	300	306	300
query28	3713	2153	2123	2123
query29	693	432	439	432
query30	226	183	177	177
query31	1004	866	825	825
query32	112	74	78	74
query33	526	347	340	340
query34	886	500	507	500
query35	867	783	749	749
query36	1092	948	957	948
query37	158	103	98	98
query38	3957	3893	3967	3893
query39	1541	1457	1468	1457
query40	229	151	149	149
query41	135	134	161	134
query42	135	115	114	114
query43	545	509	532	509
query44	1129	781	775	775
query45	224	196	192	192
query46	1122	769	756	756
query47	1929	1804	1826	1804
query48	412	328	331	328
query49	916	577	581	577
query50	864	475	467	467
query51	6901	6866	6778	6778
query52	121	104	115	104
query53	298	224	226	224
query54	616	505	507	505
query55	89	93	91	91
query56	329	316	317	316
query57	1193	1143	1134	1134
query58	286	313	304	304
query59	3088	2968	2866	2866
query60	350	326	329	326
query61	150	141	145	141
query62	799	708	703	703
query63	251	223	221	221
query64	3325	1890	1842	1842
query65	3230	3184	3181	3181
query66	1054	664	663	663
query67	15367	14932	14946	14932
query68	6052	593	587	587
query69	552	349	328	328
query70	1199	1195	1167	1167
query71	522	322	312	312
query72	6672	2294	2045	2045
query73	870	364	366	364
query74	9198	8764	8907	8764
query75	3712	2867	2772	2772
query76	2922	1018	1043	1018
query77	673	436	431	431
query78	10054	9483	9445	9445
query79	6060	560	575	560
query80	2450	629	623	623
query81	622	258	271	258
query82	738	168	156	156
query83	375	214	219	214
query84	298	98	97	97
query85	1031	346	345	345
query86	443	329	327	327
query87	4522	4172	4222	4172
query88	4342	2492	2504	2492
query89	439	325	325	325
query90	1956	233	232	232
query91	154	129	126	126
query92	92	74	74	74
query93	4191	563	547	547
query94	761	330	352	330
query95	396	299	304	299
query96	638	288	282	282
query97	3227	3085	3101	3085
query98	267	230	228	228
query99	1601	1310	1341	1310
Total cold run time: 328107 ms
Total hot run time: 196254 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 53ce3e3e3f7abec9d61d8df0f44d048a9af05df2, data reload: false

query1	0.04	0.05	0.04
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.66	0.08	0.08
query5	0.50	0.49	0.50
query6	1.12	0.73	0.73
query7	0.01	0.02	0.02
query8	0.06	0.04	0.05
query9	0.55	0.47	0.50
query10	0.56	0.54	0.54
query11	0.16	0.13	0.12
query12	0.16	0.13	0.14
query13	0.61	0.61	0.60
query14	0.77	0.78	0.78
query15	0.87	0.83	0.81
query16	0.37	0.36	0.36
query17	0.96	1.00	1.00
query18	0.23	0.22	0.22
query19	1.76	1.72	1.71
query20	0.01	0.01	0.02
query21	15.40	0.82	0.65
query22	4.98	6.41	2.06
query23	18.34	1.40	1.36
query24	2.09	0.23	0.22
query25	0.15	0.08	0.08
query26	0.31	0.22	0.22
query27	0.46	0.24	0.24
query28	13.22	1.03	1.01
query29	12.62	3.29	3.25
query30	0.37	0.19	0.18
query31	2.80	0.40	0.40
query32	3.26	0.50	0.48
query33	2.96	2.99	2.99
query34	17.16	4.34	4.32
query35	4.37	4.44	4.40
query36	0.67	0.49	0.50
query37	0.22	0.17	0.17
query38	0.17	0.16	0.16
query39	0.05	0.06	0.06
query40	0.18	0.14	0.14
query41	0.11	0.06	0.06
query42	0.07	0.06	0.06
query43	0.06	0.05	0.05
Total cold run time: 110.72 s
Total hot run time: 31.3 s

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 16, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 9ecc5ae into apache:master Aug 19, 2024
@zclllyybb zclllyybb deleted the delete_unicode branch September 15, 2024 08:48
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
## Proposed changes

Issue Number: close #xxx

before:
```sql
mysql> delete from table_7298276 where  中文列名1 > '2023-08-17' and 中文列名2 > '-68' and 中文列名3 in ("77", "0", "-35", "-8", "93", "-87", "42", "24", "57", "74");
ERROR 1105 (HY000): errCode = 2, detailMessage = delete job failed, errmsg:10019: [(10.16.10.8)[INVALID_ARGUMENT]failed to parse condition_str, condtion=TCondition {
  01: column_name (string) = "\xe4\xb8\xad\xe6\x96\x87\xe5\x88\x97\xe5\x90\x8d1",
  02: condition_op (string) = ">",
  03: condition_values (list) = list<string>[1] {
    [0] = "2023-08-17",
  },
  04: column_unique_id (i32) = 0,
  05: marked_by_runtime_filter (bool) = false,
  1000: compound_type (i32) = 0,
}]
```

now:
```sql
mysql> delete from table_7298276 where 中文列名1 > '2012-08-17' and 中文列名2 > -68 and 中文列名3 in (1,2,3);
Query OK, 0 rows affected (0.14 sec)
```
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged doing reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants