-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](delete) Support delete when column name is Unicode #39381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 37981 ms |
TPC-DS: Total hot run time: 184550 ms |
ClickBench: Total hot run time: 31.07 s |
|
run compile |
ec999eb to
53ce3e3
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 37931 ms |
TPC-DS: Total hot run time: 196254 ms |
ClickBench: Total hot run time: 31.3 s |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
## Proposed changes
Issue Number: close #xxx
before:
```sql
mysql> delete from table_7298276 where 中文列名1 > '2023-08-17' and 中文列名2 > '-68' and 中文列名3 in ("77", "0", "-35", "-8", "93", "-87", "42", "24", "57", "74");
ERROR 1105 (HY000): errCode = 2, detailMessage = delete job failed, errmsg:10019: [(10.16.10.8)[INVALID_ARGUMENT]failed to parse condition_str, condtion=TCondition {
01: column_name (string) = "\xe4\xb8\xad\xe6\x96\x87\xe5\x88\x97\xe5\x90\x8d1",
02: condition_op (string) = ">",
03: condition_values (list) = list<string>[1] {
[0] = "2023-08-17",
},
04: column_unique_id (i32) = 0,
05: marked_by_runtime_filter (bool) = false,
1000: compound_type (i32) = 0,
}]
```
now:
```sql
mysql> delete from table_7298276 where 中文列名1 > '2012-08-17' and 中文列名2 > -68 and 中文列名3 in (1,2,3);
Query OK, 0 rows affected (0.14 sec)
```
Proposed changes
Issue Number: close #xxx
before:
now: