Skip to content

[improvement](report) report handler discard old report tasks #39469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Aug 20, 2024
Merged

[improvement](report) report handler discard old report tasks #39469

dataroaring merged 2 commits into from
Aug 20, 2024

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Aug 16, 2024

improvment: when fe receive be's report tasks, dicard the old tasks.

@doris-robot
Copy link

doris-robot commented Aug 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yujun777
Copy link
Contributor Author

yujun777 commented Aug 16, 2024

run buildall

@yujun777 yujun777 marked this pull request as ready for review August 16, 2024 06:51
@yujun777
Copy link
Contributor Author

yujun777 commented Aug 16, 2024

run p0

@yujun777
Copy link
Contributor Author

yujun777 commented Aug 16, 2024

run buildall

deardeng
deardeng approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Aug 16, 2024

TPC-H: Total hot run time: 38235 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 096a5aef2d88f9bc0270fdbbe0be400daf5ceea8, data reload: false

------ Round 1 ----------------------------------
q1	17879	4382	4332	4332
q2	2060	215	208	208
q3	11759	1072	1167	1072
q4	10532	779	711	711
q5	7816	2845	2848	2845
q6	262	147	147	147
q7	982	635	636	635
q8	9575	2080	2092	2080
q9	8695	6511	6541	6511
q10	7049	2191	2202	2191
q11	477	263	258	258
q12	414	248	245	245
q13	17778	2988	2978	2978
q14	297	259	246	246
q15	552	520	534	520
q16	530	413	398	398
q17	977	733	656	656
q18	7360	6816	6742	6742
q19	6823	1097	1083	1083
q20	713	338	349	338
q21	3976	3095	3006	3006
q22	1115	1033	1034	1033
Total cold run time: 117621 ms
Total hot run time: 38235 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4670	4272	4277	4272
q2	410	288	296	288
q3	2861	2574	2701	2574
q4	1964	1702	1719	1702
q5	5698	5765	5623	5623
q6	242	151	146	146
q7	2144	1804	1738	1738
q8	3282	3585	3467	3467
q9	8788	8744	8701	8701
q10	3599	3361	3356	3356
q11	636	539	517	517
q12	880	673	674	673
q13	16143	3164	3150	3150
q14	325	294	300	294
q15	573	504	512	504
q16	491	446	448	446
q17	1828	1566	1542	1542
q18	8307	7861	7709	7709
q19	5701	1458	1641	1458
q20	2131	1908	1896	1896
q21	13823	5376	5334	5334
q22	1197	1083	1075	1075
Total cold run time: 85693 ms
Total hot run time: 56465 ms

dataroaring
dataroaring approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 967aed5 into apache:master Aug 20, 2024
@yujun777 yujun777 mentioned this pull request Aug 20, 2024
Merged
yujun777 added a commit to yujun777/doris that referenced this pull request Aug 20, 2024
@yujun777
[improvement](report) report handler discard old report tasks (apache…
5225e92 
…#39469)

improvment:  when fe receive be's report tasks, dicard the old tasks.
yiguolei pushed a commit that referenced this pull request Aug 20, 2024
@yujun777
[improvement](report) report handler discard old report tasks #39469 (#…
6078876 
…39605)

cherry pick from #39469
dataroaring pushed a commit that referenced this pull request Aug 26, 2024
@yujun777 @dataroaring
[improvement](report) report handler discard old report tasks (#39469)
b61a818 
improvment:  when fe receive be's report tasks, dicard the old tasks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@deardeng deardeng deardeng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged p0_l reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yujun777 @doris-robot @deardeng @dataroaring @yiguolei