Skip to content

[enhancement](delete) Add a hint msg for forbidden delete when MV or rollup exists #39505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Aug 18, 2024
Merged

[enhancement](delete) Add a hint msg for forbidden delete when MV or rollup exists #39505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/catalog/Partition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,4 +446,8 @@ public void convertHashDistributionToRandomDistribution() {
distributionInfo = ((HashDistributionInfo) distributionInfo).toRandomDistributionInfo();
}
}

public boolean isRollupIndex(long id) {
return idToVisibleRollupIndex.containsKey(id);
}
}
6 changes: 5 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/load/DeleteJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,13 +316,17 @@ public void dispatch() throws Exception {
() -> Maps.newTreeMap(String.CASE_INSENSITIVE_ORDER)));
for (Predicate condition : deleteConditions) {
SlotRef slotRef = (SlotRef) condition.getChild(0);
String columnName = new String(slotRef.getColumnName());
String columnName = slotRef.getColumnName();
TColumn column = colNameToColDesc.get(slotRef.getColumnName());
if (column == null) {
columnName = CreateMaterializedViewStmt.mvColumnBuilder(columnName);
column = colNameToColDesc.get(columnName);
}
if (column == null) {
if (partition.isRollupIndex(index.getId())) {
throw new AnalysisException("If MV or rollup index exists, do not support delete."
+ "Drop existing rollup or MV and try again.");
}
throw new AnalysisException(
"condition's column not founded in index, column=" + columnName + " , index=" + index);
}
Expand Down