Skip to content

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Aug 18, 2024

pick #39223 with some modifications. Optimization will only be applied to pipeline x.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhiqiang-hhhh zhiqiang-hhhh force-pushed the pick_39223_to_upstream_branch-2.1 branch from fb9c06c to c78fc0d Compare August 18, 2024 12:24
@zhiqiang-hhhh zhiqiang-hhhh changed the title [fix](memory) Disable Arrow Jemalloc step 2 (#37533) [opt](query cancel) cancel query if it has pipeline task leakage #39223 Aug 18, 2024
@zhiqiang-hhhh zhiqiang-hhhh marked this pull request as ready for review August 18, 2024 12:25
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

// We need a more detail discussion.
_query_ctx->cancel(msg, Status::Cancelled(msg));

if (reason == PPlanFragmentCancelReason::INTERNAL_ERROR && !msg.empty()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里单纯是为了输出一条log吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,不然事后无法定位问题,也不知道pipeline到底卡在哪里了。

@yiguolei yiguolei merged commit 830f250 into apache:branch-2.1 Aug 19, 2024
@zhiqiang-hhhh zhiqiang-hhhh deleted the pick_39223_to_upstream_branch-2.1 branch August 19, 2024 06:34
Gabriel39 pushed a commit that referenced this pull request Aug 22, 2024
dataroaring pushed a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants