[fix](Nereids) fix lexer Backtracking or Ambiguity cause of key word duplicate #39590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37610 ms |
morrySnow
reviewed
Aug 20, 2024
|
|
||
| BRACKETED_COMMENT | ||
| : '/*' {!isHint()}? ( BRACKETED_COMMENT | . )*? ('*/' | {markUnclosedComment();} EOF) -> channel(HIDDEN) | ||
| : COMMENT_START ( BRACKETED_COMMENT | . )*? ('*/' | {markUnclosedComment();} EOF) -> channel(HIDDEN) |
Contributor
There was a problem hiding this comment.
Suggested change
| : COMMENT_START ( BRACKETED_COMMENT | . )*? ('*/' | {markUnclosedComment();} EOF) -> channel(HIDDEN) | |
| : COMMENT_START ( BRACKETED_COMMENT | HINT_WITH_CHANNEL | . )*? ('*/' | {markUnclosedComment();} EOF) -> channel(HIDDEN) |
| ARROW: '->'; | ||
| HINT_START: '/*+'; | ||
| HINT_END: '*/'; | ||
| COMMENT_START: '/*'; |
Contributor
There was a problem hiding this comment.
add to non-reserved key word
|
|
||
| HINT_WITH_CHANNEL | ||
| : {isChannel2()}? HINT_START .*? HINT_END -> channel(2) | ||
| : HINT_START {isChannel2()}? .*? HINT_END -> channel(2) |
Contributor
There was a problem hiding this comment.
Suggested change
| : HINT_START {isChannel2()}? .*? HINT_END -> channel(2) | |
| : HINT_START {isChannel2()}? ( BRACKETED_COMMENT | HINT_WITH_CHANNEL | . )*? HINT_END -> channel(2) |
morrySnow
reviewed
Aug 20, 2024
| : COMMENT_START ( BRACKETED_COMMENT | . )*? ('*/' | {markUnclosedComment();} EOF) -> channel(HIDDEN) | ||
| ; | ||
|
|
||
| HINT_WITH_CHANNEL |
Contributor
There was a problem hiding this comment.
Suggested change
| HINT_WITH_CHANNEL | |
| HINT |
LiBinfeng-01
force-pushed
the
fix_lexer
branch
from
d894a74 to
b23587f
Compare
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
morrySnow
reviewed
Aug 20, 2024
| | COLOCATE | ||
| | COLUMNS | ||
| | COMMENT | ||
| | COMMENT_START |
Contributor
There was a problem hiding this comment.
add HINT_START HINT_END too
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37419 ms |
TPC-DS: Total hot run time: 189113 ms |
ClickBench: Total hot run time: 31.45 s |
LiBinfeng-01
force-pushed
the
fix_lexer
branch
from
5984622 to
6a222f3
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37920 ms |
TPC-DS: Total hot run time: 193830 ms |
ClickBench: Total hot run time: 30.75 s |
LiBinfeng-01
force-pushed
the
fix_lexer
branch
from
6a222f3 to
e37b3ab
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38354 ms |
TPC-DS: Total hot run time: 195202 ms |
ClickBench: Total hot run time: 31.22 s |
Contributor
Author
|
run feut |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38335 ms |
morrySnow
reviewed
Aug 21, 2024
| HINT_WITH_CHANNEL | ||
| : {isChannel2()}? HINT_START .*? HINT_END -> channel(2) | ||
| BRACKETED_COMMENT | ||
| : {isChannel()}? COMMENT_START ( BRACKETED_COMMENT | HINT | . )*? ('*/' | {markUnclosedComment();} EOF) -> channel(HIDDEN) |
LiBinfeng-01
force-pushed
the
fix_lexer
branch
from
1fb649c to
c62fe38
Compare
Contributor
Author
|
run buildall |
morrySnow
approved these changes
Aug 22, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
englefly
approved these changes
Aug 22, 2024
morrySnow
pushed a commit
that referenced
this pull request
Aug 22, 2024
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Aug 23, 2024
…duplicate (apache#39590) nereids timeout cause of parser cost too long time intro by： apache#39113 ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
gavinchou
added
dev/3.0.x
dev/3.0.x-conflict
and removed
dev/3.0.2-merged
dev/3.0.x
labels
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Sep 20, 2024
…duplicate (apache#39590) nereids timeout cause of parser cost too long time intro by： apache#39113 ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
dataroaring
pushed a commit
that referenced
this pull request
Sep 20, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Dec 11, 2024
…duplicate (apache#39590) (apache#39750) cherry-pick from master apache#39590 issue intro by apache#39416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nereids timeout cause of parser cost too long time
intro by： #39113
Proposed changes
Issue Number: close #xxx