-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](mtmv) Fix result wrong when query rewrite by mv if query contains null_unsafe equals expression #39629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
morrySnow
merged 1 commit into
apache:master
from
seawinde:fix_null_unsafe_equals_result_wrong
Aug 28, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
regression-test/data/nereids_rules_p0/mv/unsafe_equals/null_un_safe_equals.out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| -- This file is automatically generated. You should know what you did if you want to edit this | ||
| -- !query1_0_before -- | ||
| 1 o mm | ||
| 2 o mi | ||
| 4 o yy | ||
|
|
||
| -- !query1_0_after -- | ||
| 1 o mm | ||
| 2 o mi | ||
| 4 o yy | ||
|
|
85 changes: 85 additions & 0 deletions
85
regression-test/suites/nereids_rules_p0/mv/unsafe_equals/null_un_safe_equals.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| package mv.unsafe_equals | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| suite("null_unsafe_equals") { | ||
| String db = context.config.getDbNameByFile(context.file) | ||
| sql "use ${db}" | ||
| sql "set runtime_filter_mode=OFF"; | ||
| sql "SET ignore_shape_nodes='PhysicalDistribute,PhysicalProject'" | ||
|
|
||
| sql """ | ||
| drop table if exists orders | ||
| """ | ||
|
|
||
| sql """ | ||
| CREATE TABLE IF NOT EXISTS orders ( | ||
| o_orderkey INTEGER NULL, | ||
| o_custkey INTEGER NULL, | ||
| o_orderstatus CHAR(1) NULL, | ||
| o_totalprice DECIMALV3(15,2) NULL, | ||
| o_orderdate DATE NULL, | ||
| o_orderpriority CHAR(15) NULL, | ||
| o_clerk CHAR(15) NULL, | ||
| o_shippriority INTEGER NULL, | ||
| O_COMMENT VARCHAR(79) NULL | ||
| ) | ||
| DUPLICATE KEY(o_orderkey, o_custkey) | ||
| PARTITION BY RANGE(o_orderdate) ( | ||
| PARTITION `day_2` VALUES LESS THAN ('2023-12-9'), | ||
| PARTITION `day_3` VALUES LESS THAN ("2023-12-11"), | ||
| PARTITION `day_4` VALUES LESS THAN ("2023-12-30") | ||
| ) | ||
| DISTRIBUTED BY HASH(o_orderkey) BUCKETS 3 | ||
| PROPERTIES ( | ||
| "replication_num" = "1" | ||
| ); | ||
| """ | ||
|
|
||
| sql """ | ||
| insert into orders values | ||
| (null, 1, 'o', 9.5, '2023-12-08', 'a', 'b', 1, 'yy'), | ||
| (1, null, 'o', 10.5, '2023-12-08', 'a', 'b', 1, 'yy'), | ||
| (2, 1, null, 11.5, '2023-12-09', 'a', 'b', 1, 'yy'), | ||
| (3, 1, 'o', null, '2023-12-10', 'a', 'b', 1, 'yy'), | ||
| (3, 1, 'o', 33.5, null, 'a', 'b', 1, 'yy'), | ||
| (4, 2, 'o', 43.2, '2023-12-11', null,'d',2, 'mm'), | ||
| (5, 2, 'o', 56.2, '2023-12-12', 'c',null, 2, 'mi'), | ||
| (5, 2, 'o', 1.2, '2023-12-12', 'c','d', null, 'mi'); | ||
| """ | ||
|
|
||
| def mv1_0 = | ||
| """ | ||
| select count(*), o_orderstatus, o_comment | ||
| from orders | ||
| group by | ||
| o_orderstatus, o_comment; | ||
| """ | ||
| // query contains the filter which is 'o_orderstatus = o_orderstatus' should reject null | ||
| def query1_0 = | ||
| """ | ||
| select count(*), o_orderstatus, o_comment | ||
| from orders | ||
| where o_orderstatus = o_orderstatus | ||
| group by | ||
| o_orderstatus, o_comment; | ||
| """ | ||
| order_qt_query1_0_before "${query1_0}" | ||
| async_mv_rewrite_success(db, mv1_0, query1_0, "mv1_0") | ||
| order_qt_query1_0_after "${query1_0}" | ||
| sql """ DROP MATERIALIZED VIEW IF EXISTS mv1_0""" | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change set to list could fix this problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
such as the expression
o_orderstatus = o_orderstatuswe should compensateo_orderstatus = o_orderstatuson materialized view.If we record the slot equal expression in set, only get
{o_orderstatus}, inPredicates#compensateEquivalencewe couldn't compensate filter.Change set to list. we get {
o_orderstatus, o_orderstatus}, then we can compensate filter byPredicates#compensateEquivalence.