Skip to content

[fix](Nereids) fix insert into table with null literal default value (#39122) #39673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Aug 23, 2024
Merged

[fix](Nereids) fix insert into table with null literal default value (#39122) #39673

morrySnow merged 1 commit into from
Aug 23, 2024

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Aug 21, 2024

cherry-pick: #39122

Problem:
when use insert with default value null, it can not be insert successfully
Solved:
when column is allow to be null, it can be null in create table with null default value

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

doris-robot commented Aug 21, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Aug 21, 2024

run buildall

@github-actions github-actions bot added area/nereids area/planner Issues or PRs related to the query planner labels Aug 21, 2024
@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Aug 23, 2024

run buildall

@LiBinfeng-01
[fix](Nereids) fix insert into table with null literal default value (a…
160d83b 
…pache#39122)

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value
@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Aug 23, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Aug 23, 2024

TPC-H: Total hot run time: 49340 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 160d83bfa1bc08b2ea4249ce19f5e51a2dd84b8f, data reload: false

------ Round 1 ----------------------------------
q1	17775	4386	4338	4338
q2	2075	155	143	143
q3	10417	1886	1915	1886
q4	10313	1193	1318	1193
q5	8895	3877	3930	3877
q6	228	124	124	124
q7	1998	1634	1593	1593
q8	9302	2719	2700	2700
q9	10613	10283	10223	10223
q10	8637	3556	3506	3506
q11	426	257	243	243
q12	463	301	308	301
q13	18338	3968	3987	3968
q14	353	324	335	324
q15	507	458	460	458
q16	678	580	568	568
q17	1127	970	973	970
q18	7252	6709	6925	6709
q19	1683	1550	1492	1492
q20	518	282	315	282
q21	4402	4078	4054	4054
q22	496	388	394	388
Total cold run time: 116496 ms
Total hot run time: 49340 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4360	4321	4341	4321
q2	319	228	213	213
q3	4167	4128	4100	4100
q4	2721	2878	2716	2716
q5	7158	7005	7080	7005
q6	233	118	117	117
q7	3251	2887	2869	2869
q8	4379	4459	4463	4459
q9	16767	16680	16522	16522
q10	4221	4289	4249	4249
q11	727	679	676	676
q12	1010	842	836	836
q13	7004	3734	3751	3734
q14	456	429	440	429
q15	496	456	448	448
q16	745	684	699	684
q17	3862	3927	3809	3809
q18	8723	8666	8730	8666
q19	1713	1669	1626	1626
q20	2392	2112	2129	2112
q21	8409	8518	8439	8439
q22	1061	973	943	943
Total cold run time: 84174 ms
Total hot run time: 78973 ms

@doris-robot
Copy link

doris-robot commented Aug 23, 2024

TPC-DS: Total hot run time: 201849 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 160d83bfa1bc08b2ea4249ce19f5e51a2dd84b8f, data reload: false

query1	932	388	409	388
query2	6553	2112	2019	2019
query3	6932	203	198	198
query4	20164	18023	17998	17998
query5	19726	6482	6537	6482
query6	296	211	231	211
query7	4148	306	326	306
query8	281	248	242	242
query9	3134	2696	2644	2644
query10	430	302	313	302
query11	11396	10805	10752	10752
query12	124	76	75	75
query13	5597	671	649	649
query14	17773	13303	13699	13303
query15	356	224	225	224
query16	6443	285	269	269
query17	1722	1464	884	884
query18	2305	422	420	420
query19	213	151	150	150
query20	78	80	80	80
query21	191	95	91	91
query22	5236	5095	5086	5086
query23	32485	31805	31881	31805
query24	6961	6487	6490	6487
query25	514	438	426	426
query26	526	169	165	165
query27	1852	302	297	297
query28	6151	2308	2275	2275
query29	2948	2821	2678	2678
query30	241	164	163	163
query31	901	743	779	743
query32	66	62	61	61
query33	397	271	263	263
query34	835	484	482	482
query35	1132	950	897	897
query36	1559	1138	1082	1082
query37	89	60	61	60
query38	3119	2944	2943	2943
query39	1399	1329	1334	1329
query40	210	96	97	96
query41	38	37	35	35
query42	86	90	82	82
query43	618	579	581	579
query44	1134	717	716	716
query45	246	234	228	228
query46	1241	980	984	980
query47	1796	1685	1724	1685
query48	979	686	670	670
query49	615	373	376	373
query50	856	613	641	613
query51	4714	4732	4663	4663
query52	91	86	85	85
query53	449	321	324	321
query54	2650	2457	2463	2457
query55	83	85	87	85
query56	222	235	216	216
query57	1191	1083	1054	1054
query58	217	217	203	203
query59	3370	3470	3127	3127
query60	220	199	218	199
query61	100	96	97	96
query62	882	490	501	490
query63	484	346	349	346
query64	2495	1555	1540	1540
query65	3646	3548	3591	3548
query66	796	381	377	377
query67	16577	15842	15300	15300
query68	8524	662	664	662
query69	575	336	356	336
query70	1761	1379	1428	1379
query71	405	310	326	310
query72	6614	3492	3569	3492
query73	733	327	318	318
query74	6233	5848	5854	5848
query75	4696	3699	3708	3699
query76	4815	1169	1211	1169
query77	688	251	266	251
query78	12455	11660	11511	11511
query79	8508	663	641	641
query80	1277	412	403	403
query81	505	233	233	233
query82	1656	100	104	100
query83	176	135	132	132
query84	258	71	71	71
query85	912	316	338	316
query86	329	292	288	288
query87	3272	3006	2993	2993
query88	5080	2288	2279	2279
query89	393	281	302	281
query90	1951	210	215	210
query91	154	123	121	121
query92	64	55	60	55
query93	5815	561	601	561
query94	760	209	214	209
query95	1145	1077	1081	1077
query96	638	331	322	322
query97	6535	6449	6394	6394
query98	190	176	177	176
query99	3108	919	921	919
Total cold run time: 311436 ms
Total hot run time: 201849 ms

@doris-robot
Copy link

doris-robot commented Aug 23, 2024

ClickBench: Total hot run time: 30.78 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 160d83bfa1bc08b2ea4249ce19f5e51a2dd84b8f, data reload: false

query1	0.03	0.02	0.02
query2	0.07	0.03	0.03
query3	0.24	0.05	0.07
query4	1.78	0.10	0.10
query5	0.55	0.53	0.52
query6	1.26	0.61	0.61
query7	0.01	0.02	0.01
query8	0.04	0.03	0.02
query9	0.53	0.49	0.48
query10	0.52	0.52	0.53
query11	0.11	0.08	0.08
query12	0.12	0.09	0.09
query13	0.62	0.62	0.61
query14	0.79	0.79	0.80
query15	0.77	0.76	0.75
query16	0.36	0.38	0.35
query17	1.02	1.01	1.04
query18	0.21	0.26	0.25
query19	1.93	1.83	1.87
query20	0.02	0.01	0.01
query21	15.45	0.54	0.54
query22	2.05	1.91	1.47
query23	17.27	0.85	1.05
query24	4.67	4.01	1.21
query25	0.39	0.06	0.06
query26	0.86	0.17	0.15
query27	0.05	0.04	0.04
query28	5.28	0.74	0.79
query29	12.72	2.28	2.32
query30	0.64	0.53	0.51
query31	2.81	0.38	0.38
query32	3.39	0.50	0.49
query33	3.06	3.06	3.09
query34	15.25	4.79	4.78
query35	4.85	4.84	4.85
query36	1.07	1.04	1.01
query37	0.06	0.05	0.04
query38	0.03	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.15
query41	0.06	0.01	0.01
query42	0.02	0.01	0.02
query43	0.03	0.01	0.01
Total cold run time: 101.17 s
Total hot run time: 30.78 s

@doris-robot
Copy link

doris-robot commented Aug 23, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 160d83bfa1bc08b2ea4249ce19f5e51a2dd84b8f with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit e02f583 into apache:branch-2.0 Aug 23, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Dec 11, 2024
@LiBinfeng-01 @Baymine
[fix](Nereids) fix insert into table with null literal default value (a…
19400eb 
…pache#39122) (apache#39673)

cherry-pick from master apache#39122

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/nereids area/planner Issues or PRs related to the query planner reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LiBinfeng-01 @doris-robot @morrySnow