Skip to content

[fix](multi-catalog)fix max compute array and map type read offset #39680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Aug 22, 2024
Merged

[fix](multi-catalog)fix max compute array and map type read offset #39680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
177cd5a
[fix](multi-catalog)fix array and map type read offset
wsjz Aug 21, 2024
6229068
add ddl comment
wsjz Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions .../max-compute-scanner/src/main/java/org/apache/doris/maxcompute/MaxComputeColumnValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
public class MaxComputeColumnValue implements ColumnValue {
private static final Logger LOG = Logger.getLogger(MaxComputeColumnValue.class);
private int idx;
private int offset = 0; // for complex type
private ValueVector column;

public MaxComputeColumnValue() {
Expand All @@ -67,6 +68,7 @@ public MaxComputeColumnValue(ValueVector valueVector, int i) {
public void reset(ValueVector column) {
this.column = column;
this.idx = 0;
this.offset = 0;
}

@Override
Expand Down Expand Up @@ -233,26 +235,30 @@ public byte[] getBytes() {
public void unpackArray(List<ColumnValue> values) {
skippedIfNull();
ListVector listCol = (ListVector) column;
for (int i = 0; i < listCol.getDataVector().getValueCount(); i++) {
MaxComputeColumnValue val = new MaxComputeColumnValue(listCol.getDataVector(), i);
int elemSize = listCol.getObject(idx).size();
for (int i = 0; i < elemSize; i++) {
MaxComputeColumnValue val = new MaxComputeColumnValue(listCol.getDataVector(), offset);
values.add(val);
offset++;
}
idx++;
}

@Override
public void unpackMap(List<ColumnValue> keys, List<ColumnValue> values) {
skippedIfNull();
MapVector mapCol = (MapVector) column;
int elemSize = mapCol.getObject(idx).size();
FieldVector keyList = mapCol.getDataVector().getChildrenFromFields().get(0);
for (int i = 0; i < keyList.getValueCount(); i++) {
MaxComputeColumnValue val = new MaxComputeColumnValue(keyList, i);
keys.add(val);
}
FieldVector valList = mapCol.getDataVector().getChildrenFromFields().get(1);
for (int i = 0; i < valList.getValueCount(); i++) {
MaxComputeColumnValue val = new MaxComputeColumnValue(valList, i);
for (int i = 0; i < elemSize; i++) {
MaxComputeColumnValue key = new MaxComputeColumnValue(keyList, offset);
keys.add(key);
MaxComputeColumnValue val = new MaxComputeColumnValue(valList, offset);
values.add(val);
offset++;
}
idx++;
}

@Override
Expand Down
Loading