[Enhancement](FE) Make scheduler aware of interval changes immediately #39695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zclllyybb
requested review from
CalvinKirs,
dataroaring and
morningman
as code owners
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
zclllyybb
force-pushed
the
interrupt_scheduler
branch
from
c26da00 to
8474562
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38213 ms |
TPC-DS: Total hot run time: 191198 ms |
ClickBench: Total hot run time: 31.51 s |
zhangstar333
approved these changes
Aug 22, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
CalvinKirs
approved these changes
Aug 22, 2024
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Aug 23, 2024
apache#39695) Issue Number: close #xxx Before, if `dynamic_partition_check_interval_seconds` is 86400 now and we want to set it to 1, the set operation will not go into effect in 86400 seconds in worst situation. Now all set operation will norify scheduler thread and set the interval immediately. Now only applied for `DynamicPartitionScheduler`. should check other daemons in future.
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Aug 23, 2024
apache#39695) Issue Number: close #xxx Before, if `dynamic_partition_check_interval_seconds` is 86400 now and we want to set it to 1, the set operation will not go into effect in 86400 seconds in worst situation. Now all set operation will norify scheduler thread and set the interval immediately. Now only applied for `DynamicPartitionScheduler`. should check other daemons in future.
yiguolei
pushed a commit
that referenced
this pull request
Aug 24, 2024
## Proposed changes Issue Number: close #xxx #38385 optimize parsing datetime #38978 make stream load failure message more clear and disable some error's stacktrace by default #39255 fix random function coredump #39324 fix function corr inconsistency with doc #39449 check auto partitoin nullity when creating partition #39695 make DynamicPartitionScheduler immediately know interval's change #39754 Add some partition expr check on creating table
dataroaring
pushed a commit
that referenced
this pull request
Aug 26, 2024
#39695) ## Proposed changes Issue Number: close #xxx Before, if `dynamic_partition_check_interval_seconds` is 86400 now and we want to set it to 1, the set operation will not go into effect in 86400 seconds in worst situation. Now all set operation will norify scheduler thread and set the interval immediately. Now only applied for `DynamicPartitionScheduler`. should check other daemons in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Before, if
dynamic_partition_check_interval_secondsis 86400 now and we want to set it to 1, the set operation will not go into effect in 86400 seconds in worst situation.Now all set operation will norify scheduler thread and set the interval immediately.
Now only applied for
DynamicPartitionScheduler. should check other daemons in future.