-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[pick][Improment]Add schema table workload_group_privileges (#38436) #39708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| {"IS_GRANTABLE", TYPE_VARCHAR, sizeof(StringRef), true}, | ||
| }; | ||
|
|
||
| SchemaWorkloadGroupPrivilegesScanner::SchemaWorkloadGroupPrivilegesScanner() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
be/src/exec/schema_scanner/schema_workload_group_privileges.cpp:36:
- : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_WORKLOAD_GROUPS) {}
+ : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_WORKLOAD_GROUPS) = default;| SchemaWorkloadGroupPrivilegesScanner::SchemaWorkloadGroupPrivilegesScanner() | ||
| : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_WORKLOAD_GROUPS) {} | ||
|
|
||
| SchemaWorkloadGroupPrivilegesScanner::~SchemaWorkloadGroupPrivilegesScanner() {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
| SchemaWorkloadGroupPrivilegesScanner::~SchemaWorkloadGroupPrivilegesScanner() {} | |
| SchemaWorkloadGroupPrivilegesScanner::~SchemaWorkloadGroupPrivilegesScanner() = default; |
Add schema table workload_group_privileges. ``` mysql [information_schema]>desc workload_group_privileges; +---------------------+--------------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +---------------------+--------------+------+-------+---------+-------+ | GRANTEE | varchar(64) | Yes | false | NULL | | | WORKLOAD_GROUP_NAME | varchar(256) | Yes | false | NULL | | | PRIVILEGE_TYPE | varchar(64) | Yes | false | NULL | | | IS_GRANTABLE | varchar(3) | Yes | false | NULL | | +---------------------+--------------+------+-------+---------+-------+ 4 rows in set (0.01 sec) ```
09932c6 to
b84c1bc
Compare
|
run buildall |
pick #38436