[fix](ctas) fix NPE when ctas with old planner and varchar issue #39744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38644 ms |
TPC-DS: Total hot run time: 197388 ms |
ClickBench: Total hot run time: 31.05 s |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
run buildall |
TPC-H: Total hot run time: 38963 ms |
TPC-DS: Total hot run time: 193444 ms |
ClickBench: Total hot run time: 31.58 s |
morrySnow
previously approved these changes
Aug 22, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
removed
the
approved
morrySnow
approved these changes
Aug 22, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
BePPPower
approved these changes
Aug 22, 2024
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37941 ms |
TPC-DS: Total hot run time: 190681 ms |
ClickBench: Total hot run time: 30.49 s |
morningman
changed the title
morningman
added a commit
to morningman/doris
that referenced
this pull request
Aug 23, 2024
…che#39744) Fix 2 bugs: 1. introduced from apache#35489 When the target table is unpartitioned with text type column from external table, NPE will be thrown. Only happen when using old planner. The new planner works well. 2. If first column is varchar type, the new planner will change it to string type and then failed because first column can not be string type.
yiguolei
pushed a commit
that referenced
this pull request
Aug 24, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 26, 2024
) Fix 2 bugs: 1. introduced from #35489 When the target table is unpartitioned with text type column from external table, NPE will be thrown. Only happen when using old planner. The new planner works well. 2. If first column is varchar type, the new planner will change it to string type and then failed because first column can not be string type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 2 bugs:
1.
introduced from #35489
When the target table is unpartitioned with text type column from external table,
NPE will be thrown.
Only happen when using old planner.
The new planner works well.
If first column is varchar type, the new planner will change it to string type
and then failed because first column can not be string type.