[fix](nereids) Remove Nondeterministic to avoid ambiguity when decidea expression is nondeterministic or not #39801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a expression is nondeterministic or not
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
924060929
reviewed
Aug 22, 2024
Comment on lines
399
to
400
| || cachedVariable.getRealExpression().anyMatch(expr -> expr instanceof ExpressionTrait | ||
| && !((ExpressionTrait) expr).isDeterministic())) { |
Contributor
There was a problem hiding this comment.
You can remove expr instanceof ExpressionTrait because Expression is always ExpressionTrait
| * Identify the expression is containing deterministic expr or not | ||
| */ | ||
| default boolean containsNondeterministic() { | ||
| return anyMatch(expr -> expr instanceof ExpressionTrait && !((ExpressionTrait) expr).isDeterministic()); |
Contributor
There was a problem hiding this comment.
remove expr instanceof ExpressionTrait
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37853 ms |
TPC-DS: Total hot run time: 191496 ms |
ClickBench: Total hot run time: 30.42 s |
924060929
approved these changes
Aug 23, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Aug 26, 2024
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 29, 2024
…a expression is nondeterministic or not (apache#39801) ## Proposed changes In apache#36111, we add `isDeterministic` method in class `ExpressionTrait` to identify the expression is deterministic or not. But `unix_timestamp` doesn't extend Nondeterministic, but it is not deterministic when it's children is empty. and is not deterministic when children is not empty. If we use` instanceOf Nondeterministic `to indentify if expression is is not deterministic, that is confused. So we do something as fllowing: 1. Remove Nondeterministic class, and use `isDeterministic` to indentify it's deterministic. 2. Add `containsNondeterministic` method in `ExpressionTrait` to identify it contains nondeterministic expression or not. 3. `isDeterministic` only identify current expression is deterministic or not. would identify if contains nondeterministic or not
yiguolei
pushed a commit
to seawinde/doris
that referenced
this pull request
Aug 29, 2024
…a expression is nondeterministic or not (apache#39801) ## Proposed changes In apache#36111, we add `isDeterministic` method in class `ExpressionTrait` to identify the expression is deterministic or not. But `unix_timestamp` doesn't extend Nondeterministic, but it is not deterministic when it's children is empty. and is not deterministic when children is not empty. If we use` instanceOf Nondeterministic `to indentify if expression is is not deterministic, that is confused. So we do something as fllowing: 1. Remove Nondeterministic class, and use `isDeterministic` to indentify it's deterministic. 2. Add `containsNondeterministic` method in `ExpressionTrait` to identify it contains nondeterministic expression or not. 3. `isDeterministic` only identify current expression is deterministic or not. would identify if contains nondeterministic or not
yiguolei
pushed a commit
that referenced
this pull request
Aug 29, 2024
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Sep 11, 2024
…m_bytes foldable properties (apache#39944) ## Proposed changes fix the conflict between apache#39801 and apache#39891
dataroaring
pushed a commit
that referenced
this pull request
Sep 26, 2024
…a expression is nondeterministic or not (#39801) ## Proposed changes In #36111, we add `isDeterministic` method in class `ExpressionTrait` to identify the expression is deterministic or not. But `unix_timestamp` doesn't extend Nondeterministic, but it is not deterministic when it's children is empty. and is not deterministic when children is not empty. If we use` instanceOf Nondeterministic `to indentify if expression is is not deterministic, that is confused. So we do something as fllowing: 1. Remove Nondeterministic class, and use `isDeterministic` to indentify it's deterministic. 2. Add `containsNondeterministic` method in `ExpressionTrait` to identify it contains nondeterministic expression or not. 3. `isDeterministic` only identify current expression is deterministic or not. would identify if contains nondeterministic or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In #36111, we add
isDeterministicmethod in classExpressionTraitto identify the expression is deterministic or not.But
unix_timestampdoesn't extend Nondeterministic, but it is not deterministic when it's children is empty. and is not deterministic when children is not empty. If we useinstanceOf Nondeterministicto indentify if expression is is not deterministic, that is confused.So we do something as fllowing:
isDeterministicto indentify it's deterministic.containsNondeterministicmethod inExpressionTraitto identify it contains nondeterministic expression or not.isDeterministiconly identify current expression is deterministic or not. would identify if contains nondeterministic or not