[improvement](jdbc catalog) support jdbc external catalog insert stmt in nereids #39813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zy-kkk
force-pushed
the
jdbc_sink_new_plan
branch
from
532f354 to
559b20c
Compare
Member
Author
|
run buildall |
TPC-H: Total hot run time: 37773 ms |
TPC-DS: Total hot run time: 190838 ms |
ClickBench: Total hot run time: 31.47 s |
morrySnow
reviewed
Sep 5, 2024
Comment on lines
63
to
64
| return new UnboundJdbcTableSink<>(nameParts, colNames, hints, partitions, | ||
| dmlCommandType, groupExpression, Optional.empty(), children.get(0)); |
Contributor
There was a problem hiding this comment.
with children should not inherit groupExpression use Optional.empty()
| @Override | ||
| public Void visitPhysicalJdbcTableSink( | ||
| PhysicalJdbcTableSink<? extends Plan> jdbcTableSink, PlanContext context) { | ||
| if (connectContext != null && !connectContext.getSessionVariable().enableStrictConsistencyDml) { |
Contributor
There was a problem hiding this comment.
i think jdbc sink should always use gather properties
| dmlCommandType, Optional.empty(), Optional.empty(), plan); | ||
| } | ||
| // TODO: we need to support insert into other catalog | ||
| try { |
Contributor
There was a problem hiding this comment.
remove these force fallback code
zy-kkk
force-pushed
the
jdbc_sink_new_plan
branch
from
559b20c to
9da9724
Compare
Member
Author
|
run buildall |
zy-kkk
changed the title
TPC-H: Total hot run time: 38234 ms |
TPC-DS: Total hot run time: 187543 ms |
ClickBench: Total hot run time: 31.56 s |
morrySnow
previously approved these changes
Sep 6, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
zy-kkk
force-pushed
the
jdbc_sink_new_plan
branch
from
9da9724 to
4d4ccbc
Compare
Member
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 38380 ms |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
morrySnow
approved these changes
Sep 11, 2024
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Sep 18, 2024
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.