Skip to content

Conversation

@morningman
Copy link
Contributor

bp #38746

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

{"PROPERTY_VALUE", TYPE_STRING, sizeof(StringRef), true},
};

SchemaTablePropertiesScanner::SchemaTablePropertiesScanner()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]

be/src/exec/schema_scanner/schema_table_properties_scanner.cpp:38:

-         : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_TABLE_PROPERTIES) {}
+         : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_TABLE_PROPERTIES) = default;

// under the License.

#pragma once
#include <gen_cpp/FrontendService_types.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/FrontendService_types.h' file not found [clang-diagnostic-error]

#include <gen_cpp/FrontendService_types.h>
         ^

@morningman
Copy link
Contributor Author

run buildall

…pache#38746)

Issue Number: close apache#38745

added table_properties schema table, with displaying property info in
multiple rows.

![image](https://github.com/user-attachments/assets/949afe37-9895-4ac0-8e4d-e320a06ad500)

few more modifications.
1)  properties removed from table_options.
2) table options schema order changed starting from
TABLE_CATALOG,TABLE_SCHEMA,TABLE_NAME ...
@morningman
Copy link
Contributor Author

run buildall

@morningman
Copy link
Contributor Author

run buildall

@morningman
Copy link
Contributor Author

run buildall

@morningman morningman merged commit 173aafc into apache:branch-2.1 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants