Skip to content

[fix](replay) fix replay ReplicaPersistInfo no update lastFailedVersion and lastSuccVersion #39918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Aug 26, 2024
Merged

[fix](replay) fix replay ReplicaPersistInfo no update lastFailedVersion and lastSuccVersion #39918

dataroaring merged 1 commit into from
Aug 26, 2024

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Aug 26, 2024

No description provided.

@doris-robot
Copy link

doris-robot commented Aug 26, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yujun777
Copy link
Contributor Author

yujun777 commented Aug 26, 2024

run buildall

deardeng
deardeng approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Aug 26, 2024

TPC-H: Total hot run time: 37904 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 517c5d2e771bf6b0c18848b55ae85ef212fa7d10, data reload: false

------ Round 1 ----------------------------------
q1	17631	4356	4298	4298
q2	2021	182	177	177
q3	11749	952	1179	952
q4	10531	692	797	692
q5	7731	2840	2842	2840
q6	222	134	137	134
q7	969	609	593	593
q8	9340	2037	2062	2037
q9	7281	6511	6541	6511
q10	6994	2207	2223	2207
q11	449	247	248	247
q12	390	223	225	223
q13	18072	3033	3006	3006
q14	269	236	236	236
q15	529	490	497	490
q16	490	401	404	401
q17	989	664	684	664
q18	7313	6792	6803	6792
q19	1384	1139	1066	1066
q20	686	334	322	322
q21	3831	3056	2991	2991
q22	1160	1034	1025	1025
Total cold run time: 110031 ms
Total hot run time: 37904 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4368	4304	4316	4304
q2	383	273	282	273
q3	2864	2661	2620	2620
q4	1955	1662	1664	1662
q5	5560	5642	5707	5642
q6	259	148	136	136
q7	2260	1815	1841	1815
q8	3305	3449	3439	3439
q9	8849	8871	8790	8790
q10	3585	3432	3355	3355
q11	605	508	522	508
q12	881	664	647	647
q13	15550	3205	3276	3205
q14	325	289	301	289
q15	530	487	510	487
q16	477	466	440	440
q17	1829	1535	1521	1521
q18	8077	7817	7898	7817
q19	1725	1510	1644	1510
q20	2153	1922	1902	1902
q21	5727	5559	5407	5407
q22	1149	1087	1061	1061
Total cold run time: 72416 ms
Total hot run time: 56830 ms

@doris-robot
Copy link

doris-robot commented Aug 26, 2024

TPC-DS: Total hot run time: 191105 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 517c5d2e771bf6b0c18848b55ae85ef212fa7d10, data reload: false

query1	1244	896	866	866
query2	6343	1917	1876	1876
query3	10709	4058	3930	3930
query4	60193	28303	23064	23064
query5	5303	505	509	505
query6	405	171	163	163
query7	5777	289	290	289
query8	290	204	219	204
query9	8858	2494	2469	2469
query10	493	292	276	276
query11	18218	15101	15479	15101
query12	165	112	119	112
query13	1614	376	383	376
query14	10639	6593	7428	6593
query15	234	172	183	172
query16	7460	485	496	485
query17	1115	584	578	578
query18	1325	301	292	292
query19	292	143	155	143
query20	126	114	114	114
query21	207	111	112	111
query22	4591	4694	4645	4645
query23	34391	33241	33455	33241
query24	5953	2856	2830	2830
query25	517	374	377	374
query26	691	159	154	154
query27	1770	282	276	276
query28	3637	2052	2034	2034
query29	643	403	402	402
query30	236	153	149	149
query31	909	774	751	751
query32	81	56	59	56
query33	464	286	284	284
query34	843	469	465	465
query35	838	745	753	745
query36	1032	925	911	911
query37	145	86	84	84
query38	4076	3968	3808	3808
query39	1442	1377	1412	1377
query40	207	120	118	118
query41	48	48	46	46
query42	114	97	99	97
query43	504	479	479	479
query44	1080	743	762	743
query45	200	165	169	165
query46	1097	760	729	729
query47	1875	1810	1856	1810
query48	382	352	299	299
query49	755	432	429	429
query50	822	421	402	402
query51	7176	7172	7019	7019
query52	100	89	90	89
query53	253	181	177	177
query54	551	454	463	454
query55	76	74	75	74
query56	268	247	257	247
query57	1178	1086	1075	1075
query58	212	238	223	223
query59	2967	2751	2752	2751
query60	301	269	263	263
query61	105	100	137	100
query62	761	636	681	636
query63	219	180	182	180
query64	3329	1775	1756	1756
query65	3164	3192	3136	3136
query66	656	338	337	337
query67	15373	15265	15381	15265
query68	2987	564	555	555
query69	400	288	293	288
query70	1180	1109	1101	1101
query71	350	275	277	275
query72	2570	2090	2117	2090
query73	710	320	322	320
query74	9089	8815	8902	8815
query75	3348	2645	2721	2645
query76	1445	1007	966	966
query77	504	325	323	323
query78	10082	9087	9005	9005
query79	1023	533	535	533
query80	697	509	508	508
query81	457	231	224	224
query82	285	142	137	137
query83	166	149	147	147
query84	258	75	79	75
query85	675	290	283	283
query86	297	291	293	291
query87	4316	4303	4277	4277
query88	3214	2324	2349	2324
query89	371	281	278	278
query90	1926	196	198	196
query91	142	112	110	110
query92	63	52	128	52
query93	1037	530	535	530
query94	713	288	286	286
query95	334	263	267	263
query96	585	270	272	270
query97	3177	3083	3114	3083
query98	209	207	195	195
query99	1484	1293	1256	1256
Total cold run time: 301136 ms
Total hot run time: 191105 ms

@doris-robot
Copy link

doris-robot commented Aug 26, 2024

ClickBench: Total hot run time: 30.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 517c5d2e771bf6b0c18848b55ae85ef212fa7d10, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.06	0.05
query4	1.67	0.09	0.09
query5	0.52	0.51	0.50
query6	1.13	0.74	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.48	0.47
query10	0.54	0.55	0.54
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.63	0.59	0.59
query14	0.76	0.81	0.77
query15	0.83	0.82	0.81
query16	0.38	0.37	0.38
query17	1.07	1.03	1.06
query18	0.21	0.21	0.22
query19	1.80	1.86	1.82
query20	0.01	0.01	0.00
query21	15.39	0.67	0.66
query22	4.56	6.89	1.91
query23	18.25	1.33	1.36
query24	2.07	0.22	0.23
query25	0.17	0.08	0.08
query26	0.27	0.19	0.18
query27	0.08	0.07	0.07
query28	13.21	1.01	0.99
query29	12.58	3.36	3.28
query30	0.24	0.06	0.06
query31	2.88	0.40	0.38
query32	3.24	0.47	0.48
query33	2.97	3.01	3.05
query34	17.18	4.40	4.42
query35	4.52	4.51	4.47
query36	0.65	0.49	0.48
query37	0.18	0.16	0.17
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.15	0.14	0.14
query41	0.09	0.04	0.04
query42	0.07	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.82 s
Total hot run time: 30.95 s

@yujun777
Copy link
Contributor Author

yujun777 commented Aug 26, 2024

run p0

@yujun777
Copy link
Contributor Author

yujun777 commented Aug 26, 2024

run cloud_p0

dataroaring
dataroaring approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 26, 2024
@dataroaring dataroaring merged commit 014b504 into apache:master Aug 26, 2024
@yujun777 yujun777 mentioned this pull request Aug 27, 2024
Merged
yujun777 added a commit to yujun777/doris that referenced this pull request Aug 27, 2024
@yujun777
[fix](replay) fix replay ReplicaPersistInfo no update lastFailedVersi…
84282e1 
…on and lastSuccVersion (apache#39918)
@yujun777 yujun777 mentioned this pull request Aug 27, 2024
Merged
dataroaring pushed a commit that referenced this pull request Aug 27, 2024
@yujun777
[fix](replay) fix replay ReplicaPersistInfo no update lastFailedVersi…
959ea27 
…on and lastSuccVersion #39918 (#39947)

cherry pick from #39918
dataroaring pushed a commit that referenced this pull request Aug 27, 2024
@yujun777
[fix](replay) fix replay ReplicaPersistInfo no update lastFailedVersi…
bb5cbce 
…on and lastSuccVersion #39918 (#39950)

cherry pick from #39918
dataroaring pushed a commit that referenced this pull request Aug 27, 2024
@yujun777 @dataroaring
[fix](replay) fix replay ReplicaPersistInfo no update lastFailedVersi…
5c5b577 
…on and lastSuccVersion (#39918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@deardeng deardeng deardeng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.15-merged dev/2.1.6-merged dev/3.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yujun777 @doris-robot @deardeng @dataroaring