-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Cache][BE] LRU cache for sql/partition cache #2581 #4005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
Jul 2, 2020
Contributor
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing partition_cache_test file?
This was referenced Jul 10, 2020
b48c5b4 to
311dccb
Compare
wutiangan
reviewed
Aug 4, 2020
wutiangan
previously approved these changes
Aug 5, 2020
c17a20e to
a285246
Compare
wutiangan
previously approved these changes
Aug 10, 2020
a285246 to
3ee304e
Compare
wutiangan
previously approved these changes
Aug 10, 2020
dfb1f6d to
0015dca
Compare
wutiangan
previously approved these changes
Aug 22, 2020
wuyunfeng
reviewed
Aug 24, 2020
morningman
reviewed
Aug 24, 2020
f328607 to
b0ad2e2
Compare
1. Cache data by sql key and partition key 2. Support fetch/update/clear operator 3. Hit cache by key, version and vertion_time
a951bc4 to
24d78f2
Compare
Contributor
|
Still has memory leak in UT |
24d78f2 to
768367f
Compare
768367f to
6afcb27
Compare
morningman
approved these changes
Sep 19, 2020
Contributor
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
area/sql/execution
Issues or PRs related to the execution engine
kind/feature
Categorizes issue or PR as related to a new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Cache fetch
Cache update
Cache pruning