[opt](file-cache) support system table file_cache_statistics #40078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| {"METRIC_NAME", TYPE_VARCHAR, sizeof(StringRef), false}, | ||
| {"METRIC_VALUE", TYPE_DOUBLE, sizeof(double), false}}; | ||
|
|
||
| SchemaFileCacheStatisticsScanner::SchemaFileCacheStatisticsScanner() |
Contributor
There was a problem hiding this comment.
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
be/src/exec/schema_scanner/schema_file_cache_statistics.cpp:37:
- : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_FILE_CACHE_STATISTICS) {}
+ : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_FILE_CACHE_STATISTICS) = default;| SchemaFileCacheStatisticsScanner::SchemaFileCacheStatisticsScanner() | ||
| : SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_FILE_CACHE_STATISTICS) {} | ||
|
|
||
| SchemaFileCacheStatisticsScanner::~SchemaFileCacheStatisticsScanner() {} |
Contributor
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
Suggested change
| SchemaFileCacheStatisticsScanner::~SchemaFileCacheStatisticsScanner() {} | |
| SchemaFileCacheStatisticsScanner::~SchemaFileCacheStatisticsScanner() = default; |
gavinchou
reviewed
Aug 28, 2024
morningman
force-pushed
the
cache_sys_table_master
branch
from
1d9a5e6 to
e0ecf97
Compare
morningman
force-pushed
the
cache_sys_table_master
branch
from
4dae78d to
d16943c
Compare
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
Contributor
|
PR approved by anyone and no changes requested. |
zy-kkk
approved these changes
Oct 14, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
qzsee
pushed a commit
to qzsee/incubator-doris
that referenced
this pull request
Oct 16, 2024
…40078) 1. Add new system table: `file_cache_statistics` This table is used for viewing metrics related to file cache on BE side ``` mysql> select * from information_schema.file_cache_statistics limit 10; +-------+---------------+----------------------------+--------------------------------+--------------------+ | BE_ID | BE_IP | CACHE_PATH | METRIC_NAME | METRIC_VALUE | +-------+---------------+----------------------------+--------------------------------+--------------------+ | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | disposable_queue_curr_elements | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | disposable_queue_curr_size | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | disposable_queue_max_elements | 102400 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | disposable_queue_max_size | 21474836480 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | hits_ratio | 0.8539634687001242 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | hits_ratio_1h | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | hits_ratio_5m | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | index_queue_curr_elements | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | index_queue_curr_size | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | index_queue_max_elements | 102400 | +-------+---------------+----------------------------+--------------------------------+--------------------+ ``` It will show metrics of file caches on each BE. 2. Add new metrics `hits_ratio_1h` and `hits_ratio_5m` for file cache This 2 metrics will show the hit ratio of file cache in recent 1 hour or 5 minutes. So that we can know recent hit ratio instead of global historical hit ratio.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Oct 21, 2024
…40078) 1. Add new system table: `file_cache_statistics` This table is used for viewing metrics related to file cache on BE side ``` mysql> select * from information_schema.file_cache_statistics limit 10; +-------+---------------+----------------------------+--------------------------------+--------------------+ | BE_ID | BE_IP | CACHE_PATH | METRIC_NAME | METRIC_VALUE | +-------+---------------+----------------------------+--------------------------------+--------------------+ | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | disposable_queue_curr_elements | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | disposable_queue_curr_size | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | disposable_queue_max_elements | 102400 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | disposable_queue_max_size | 21474836480 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | hits_ratio | 0.8539634687001242 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | hits_ratio_1h | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | hits_ratio_5m | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | index_queue_curr_elements | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | index_queue_curr_size | 0 | | 10003 | 172.20.32.136 | /mnt/output/be/file_cache/ | index_queue_max_elements | 102400 | +-------+---------------+----------------------------+--------------------------------+--------------------+ ``` It will show metrics of file caches on each BE. 2. Add new metrics `hits_ratio_1h` and `hits_ratio_5m` for file cache This 2 metrics will show the hit ratio of file cache in recent 1 hour or 5 minutes. So that we can know recent hit ratio instead of global historical hit ratio.
morningman
added a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new system table:
file_cache_statisticsThis table is used for viewing metrics related to file cache on BE side
It will show metrics of file caches on each BE.
Add new metrics
hits_ratio_1handhits_ratio_5mfor file cacheThis 2 metrics will show the hit ratio of file cache in recent 1 hour or 5 minutes.
So that we can know recent hit ratio instead of global historical hit ratio.