-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](function)Some geo functions incorrectly used get. #40107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38078 ms |
TPC-DS: Total hot run time: 192621 ms |
ClickBench: Total hot run time: 31.64 s |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 38703 ms |
TPC-DS: Total hot run time: 193068 ms |
ClickBench: Total hot run time: 32.54 s |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37937 ms |
TPC-DS: Total hot run time: 192161 ms |
ClickBench: Total hot run time: 32.38 s |
## Proposed changes ``` mysql [test]>select count(st_distance_sphere(db, db, db, db)) from double_ranges; +-------------------------------------------+ | count(st_distance_sphere(db, db, db, db)) | +-------------------------------------------+ | 0 | +-------------------------------------------+ 1 row in set (1.25 sec) mysql [test]>select count(st_distance_sphere(db, db, db, db)) from double_ranges; +-------------------------------------------+ | count(st_distance_sphere(db, db, db, db)) | +-------------------------------------------+ | 0 | +-------------------------------------------+ 1 row in set (0.33 sec) ``` <!--Describe your changes.-->
…Sphere (#45508) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #40107 Problem Summary: In #40107 we introduced a wrong behaviour which would lead to BE crash because of dangling reference. now fix it. ### Release note fix BE crash of function StDistanceSphere and StAngleSphere ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…Sphere (apache#45508) ### What problem does this PR solve? Issue Number: close #xxx Related PR: apache#40107 Problem Summary: In apache#40107 we introduced a wrong behaviour which would lead to BE crash because of dangling reference. now fix it. ### Release note fix BE crash of function StDistanceSphere and StAngleSphere ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Proposed changes