Skip to content

Conversation

@suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Aug 30, 2024

followup #38549
If the large_block_len is 0, should not continue reading the block_len.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@suxiaogang223
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38168 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3407a799e63c38d32d2d803e9a2b4faaba1a17e1, data reload: false

------ Round 1 ----------------------------------
q1	18171	4511	4373	4373
q2	2593	180	190	180
q3	11038	1129	1039	1039
q4	10459	727	737	727
q5	8170	2910	2840	2840
q6	236	141	141	141
q7	962	627	627	627
q8	9739	2059	2036	2036
q9	7093	6558	6563	6558
q10	7017	2167	2237	2167
q11	444	233	245	233
q12	397	232	223	223
q13	17811	3046	3038	3038
q14	271	231	242	231
q15	528	484	497	484
q16	593	530	508	508
q17	979	701	617	617
q18	7319	6802	6901	6802
q19	1391	1134	1138	1134
q20	683	338	332	332
q21	3925	3160	2894	2894
q22	1105	1025	984	984
Total cold run time: 110924 ms
Total hot run time: 38168 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4376	4316	4290	4290
q2	390	272	278	272
q3	2888	2682	2618	2618
q4	1910	1658	1655	1655
q5	5399	5385	5374	5374
q6	217	129	127	127
q7	2080	1752	1707	1707
q8	3218	3390	3346	3346
q9	8384	8446	8394	8394
q10	3473	3216	3178	3178
q11	602	505	493	493
q12	788	628	627	627
q13	10393	3031	3020	3020
q14	298	279	281	279
q15	522	499	474	474
q16	591	551	581	551
q17	1771	1487	1483	1483
q18	7705	7471	7469	7469
q19	1676	1589	1632	1589
q20	2069	1782	1829	1782
q21	5469	5356	5204	5204
q22	1141	1008	1030	1008
Total cold run time: 65360 ms
Total hot run time: 54940 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188306 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3407a799e63c38d32d2d803e9a2b4faaba1a17e1, data reload: false

query1	903	373	365	365
query2	6455	1909	1922	1909
query3	6643	209	222	209
query4	31344	23121	23168	23121
query5	4192	518	495	495
query6	266	163	174	163
query7	4584	295	284	284
query8	262	214	211	211
query9	8483	2450	2461	2450
query10	447	263	259	259
query11	15515	15255	15117	15117
query12	160	104	97	97
query13	1617	387	371	371
query14	9817	7173	7218	7173
query15	259	167	177	167
query16	8015	469	465	465
query17	1598	576	565	565
query18	2128	301	300	300
query19	336	151	149	149
query20	118	115	112	112
query21	215	105	113	105
query22	4420	4217	4060	4060
query23	34105	33654	33246	33246
query24	11246	2853	2849	2849
query25	643	414	406	406
query26	1333	164	169	164
query27	2772	286	281	281
query28	7634	2100	2092	2092
query29	868	430	426	426
query30	308	158	159	158
query31	976	743	781	743
query32	97	58	65	58
query33	769	327	301	301
query34	913	499	475	475
query35	863	741	728	728
query36	1115	920	988	920
query37	172	99	96	96
query38	4032	3828	3848	3828
query39	1458	1432	1414	1414
query40	263	122	120	120
query41	52	48	48	48
query42	117	99	100	99
query43	504	457	470	457
query44	1248	760	752	752
query45	195	171	169	169
query46	1099	735	758	735
query47	1857	1776	1793	1776
query48	382	301	315	301
query49	1108	438	447	438
query50	817	421	410	410
query51	7155	7154	7099	7099
query52	101	92	91	91
query53	269	193	191	191
query54	993	464	467	464
query55	78	86	88	86
query56	295	259	267	259
query57	1199	1085	1041	1041
query58	247	231	238	231
query59	2920	2868	2868	2868
query60	307	282	282	282
query61	129	123	120	120
query62	824	653	670	653
query63	228	192	189	189
query64	5376	789	680	680
query65	3307	3171	3158	3158
query66	1432	340	334	334
query67	15638	15186	15156	15156
query68	4667	567	557	557
query69	475	306	278	278
query70	1134	1092	1058	1058
query71	415	279	282	279
query72	7391	4030	3987	3987
query73	761	332	333	332
query74	9121	8890	8929	8890
query75	3728	2665	2679	2665
query76	2997	991	987	987
query77	514	320	333	320
query78	9900	9108	9118	9108
query79	1529	522	533	522
query80	924	497	498	497
query81	590	235	240	235
query82	816	147	143	143
query83	249	153	148	148
query84	235	74	83	74
query85	1331	290	319	290
query86	383	302	300	300
query87	4327	4251	4323	4251
query88	3029	2344	2334	2334
query89	381	293	296	293
query90	1837	205	201	201
query91	124	104	97	97
query92	64	53	52	52
query93	1164	538	530	530
query94	978	304	311	304
query95	359	266	265	265
query96	605	268	269	268
query97	3152	3095	3045	3045
query98	221	210	205	205
query99	1502	1263	1252	1252
Total cold run time: 290124 ms
Total hot run time: 188306 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3407a799e63c38d32d2d803e9a2b4faaba1a17e1, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.23	0.05	0.04
query4	1.67	0.08	0.07
query5	0.49	0.49	0.50
query6	1.13	0.73	0.72
query7	0.01	0.01	0.02
query8	0.05	0.05	0.05
query9	0.55	0.50	0.49
query10	0.55	0.53	0.56
query11	0.16	0.11	0.12
query12	0.14	0.13	0.12
query13	0.62	0.60	0.59
query14	2.02	2.09	2.10
query15	0.90	0.82	0.82
query16	0.37	0.38	0.37
query17	1.05	1.02	1.02
query18	0.21	0.20	0.21
query19	1.88	1.71	1.75
query20	0.01	0.01	0.01
query21	15.40	0.68	0.67
query22	4.39	6.49	2.16
query23	18.33	1.42	1.33
query24	2.14	0.22	0.24
query25	0.14	0.07	0.08
query26	0.26	0.18	0.18
query27	0.08	0.07	0.08
query28	13.23	1.01	1.01
query29	12.61	3.35	3.30
query30	0.24	0.06	0.05
query31	2.87	0.40	0.38
query32	3.27	0.49	0.47
query33	2.94	3.07	3.02
query34	16.87	4.41	4.38
query35	4.43	4.44	4.45
query36	0.66	0.48	0.49
query37	0.18	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.12	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.76 s
Total hot run time: 32.35 s

@suxiaogang223
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 37872 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 43627e81a64caf42677fe43719694d6a1e3d2f40, data reload: false

------ Round 1 ----------------------------------
q1	17648	4418	4306	4306
q2	2041	190	168	168
q3	10477	1160	1068	1068
q4	10138	806	663	663
q5	7705	2865	2809	2809
q6	227	138	138	138
q7	969	615	591	591
q8	9339	2098	2090	2090
q9	7008	6499	6505	6499
q10	7003	2122	2229	2122
q11	458	238	253	238
q12	394	227	227	227
q13	17882	3005	3001	3001
q14	278	246	234	234
q15	516	478	493	478
q16	600	510	507	507
q17	968	734	707	707
q18	7293	6930	6805	6805
q19	1409	922	985	922
q20	684	330	345	330
q21	3921	2972	2975	2972
q22	1113	997	1024	997
Total cold run time: 108071 ms
Total hot run time: 37872 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4329	4305	4259	4259
q2	388	278	283	278
q3	2877	2634	2684	2634
q4	1922	1613	1663	1613
q5	5471	5389	5353	5353
q6	218	129	132	129
q7	2108	1751	1736	1736
q8	3211	3321	3373	3321
q9	8400	8402	8442	8402
q10	3442	3222	3210	3210
q11	606	488	498	488
q12	781	596	604	596
q13	13138	3020	3032	3020
q14	304	279	285	279
q15	534	490	476	476
q16	624	576	571	571
q17	1766	1489	1488	1488
q18	7673	7439	7456	7439
q19	1671	1526	1515	1515
q20	2023	1806	1834	1806
q21	5327	5273	5167	5167
q22	1076	1042	1031	1031
Total cold run time: 67889 ms
Total hot run time: 54811 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187641 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 43627e81a64caf42677fe43719694d6a1e3d2f40, data reload: false

query1	900	374	359	359
query2	6445	1966	1953	1953
query3	6637	202	219	202
query4	33949	23223	23290	23223
query5	4173	506	485	485
query6	251	172	160	160
query7	4582	299	283	283
query8	248	197	209	197
query9	8562	2450	2461	2450
query10	440	267	267	267
query11	17739	15040	14998	14998
query12	148	98	97	97
query13	1622	376	365	365
query14	9333	7036	6673	6673
query15	256	166	179	166
query16	7886	449	438	438
query17	1565	559	538	538
query18	2060	292	290	290
query19	194	147	141	141
query20	114	107	111	107
query21	207	103	102	102
query22	4386	4295	4164	4164
query23	33993	33577	33450	33450
query24	11190	2866	2815	2815
query25	614	372	372	372
query26	1168	162	160	160
query27	2807	279	274	274
query28	7622	2108	2078	2078
query29	844	405	413	405
query30	301	159	154	154
query31	981	781	782	781
query32	96	57	60	57
query33	753	286	283	283
query34	980	466	486	466
query35	855	748	711	711
query36	1078	922	925	922
query37	164	94	89	89
query38	4053	3896	3804	3804
query39	1426	1394	1387	1387
query40	199	118	120	118
query41	47	48	46	46
query42	114	95	96	95
query43	510	479	465	465
query44	1195	756	738	738
query45	201	172	169	169
query46	1111	745	739	739
query47	1927	1834	1842	1834
query48	387	310	293	293
query49	1094	451	442	442
query50	808	408	416	408
query51	7251	7107	6952	6952
query52	103	88	89	88
query53	266	194	184	184
query54	913	462	467	462
query55	83	78	78	78
query56	287	269	264	264
query57	1165	1096	1089	1089
query58	250	241	256	241
query59	3086	2966	2697	2697
query60	301	276	275	275
query61	123	119	120	119
query62	848	653	659	653
query63	219	186	185	185
query64	5421	765	733	733
query65	3215	3151	3182	3151
query66	1447	342	355	342
query67	15637	15296	15232	15232
query68	4390	557	548	548
query69	413	289	287	287
query70	1090	1130	1120	1120
query71	339	278	279	278
query72	6688	4201	4005	4005
query73	756	333	336	333
query74	9108	8857	8960	8857
query75	3530	2676	2681	2676
query76	2268	1009	983	983
query77	496	317	342	317
query78	10008	9054	9002	9002
query79	2405	527	548	527
query80	1218	499	490	490
query81	590	239	235	235
query82	746	143	150	143
query83	215	151	150	150
query84	225	78	77	77
query85	1625	290	289	289
query86	472	296	295	295
query87	4391	4356	4284	4284
query88	3476	2344	2306	2306
query89	408	292	297	292
query90	1828	196	196	196
query91	123	101	97	97
query92	65	54	49	49
query93	1614	532	521	521
query94	963	265	284	265
query95	364	259	258	258
query96	599	267	265	265
query97	3197	3076	3114	3076
query98	217	206	204	204
query99	1658	1258	1280	1258
Total cold run time: 294315 ms
Total hot run time: 187641 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 43627e81a64caf42677fe43719694d6a1e3d2f40, data reload: false

query1	0.04	0.04	0.04
query2	0.09	0.04	0.04
query3	0.22	0.06	0.05
query4	1.67	0.08	0.09
query5	0.51	0.50	0.49
query6	1.13	0.74	0.72
query7	0.02	0.01	0.02
query8	0.06	0.04	0.05
query9	0.55	0.50	0.49
query10	0.54	0.54	0.54
query11	0.16	0.12	0.11
query12	0.16	0.13	0.13
query13	0.62	0.58	0.59
query14	2.09	2.04	2.06
query15	0.84	0.82	0.81
query16	0.40	0.37	0.37
query17	0.98	0.99	0.98
query18	0.21	0.21	0.20
query19	1.82	1.77	1.74
query20	0.01	0.01	0.02
query21	15.41	0.68	0.67
query22	3.81	6.59	2.79
query23	18.30	1.45	1.29
query24	2.09	0.22	0.24
query25	0.16	0.09	0.08
query26	0.26	0.19	0.18
query27	0.08	0.08	0.08
query28	13.24	1.01	1.00
query29	12.63	3.30	3.30
query30	0.24	0.06	0.06
query31	2.87	0.40	0.39
query32	3.26	0.47	0.47
query33	2.96	2.94	3.01
query34	16.99	4.38	4.40
query35	4.42	4.42	4.42
query36	0.65	0.48	0.47
query37	0.18	0.16	0.16
query38	0.16	0.14	0.14
query39	0.04	0.03	0.04
query40	0.15	0.14	0.13
query41	0.09	0.04	0.05
query42	0.06	0.05	0.05
query43	0.04	0.05	0.04
Total cold run time: 110.21 s
Total hot run time: 32.8 s

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 31, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman force-pushed the fix_block_decompressor branch from 43627e8 to e2864fd Compare September 1, 2024 15:20
@morningman
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38012 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e2864fda9c8a27b21de5c9d4e49cc64dbfefd7bc, data reload: false

------ Round 1 ----------------------------------
q1	17618	4354	4261	4261
q2	2029	177	180	177
q3	11788	983	1205	983
q4	10529	713	773	713
q5	7773	2818	2786	2786
q6	228	139	135	135
q7	968	597	602	597
q8	9340	2075	2056	2056
q9	7065	6536	6560	6536
q10	7008	2248	2250	2248
q11	454	250	244	244
q12	392	224	225	224
q13	17820	3075	3014	3014
q14	273	245	230	230
q15	513	480	498	480
q16	589	522	507	507
q17	973	678	730	678
q18	7282	6807	6906	6807
q19	1397	1094	1053	1053
q20	657	324	336	324
q21	4052	3017	2940	2940
q22	1121	1040	1019	1019
Total cold run time: 109869 ms
Total hot run time: 38012 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4321	4289	4278	4278
q2	376	268	267	267
q3	2887	2636	2640	2636
q4	1934	1677	1688	1677
q5	5569	5695	5718	5695
q6	223	132	137	132
q7	2256	1770	1865	1770
q8	3281	3412	3385	3385
q9	8811	8858	8839	8839
q10	3591	3347	3369	3347
q11	603	510	516	510
q12	838	641	675	641
q13	15614	3168	3274	3168
q14	321	297	292	292
q15	535	489	502	489
q16	629	563	560	560
q17	1850	1529	1514	1514
q18	8116	7778	7750	7750
q19	1719	1549	1586	1549
q20	2133	1967	1913	1913
q21	5718	5399	5118	5118
q22	1134	1053	1035	1035
Total cold run time: 72459 ms
Total hot run time: 56565 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193784 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e2864fda9c8a27b21de5c9d4e49cc64dbfefd7bc, data reload: false

query1	1267	905	876	876
query2	6343	1975	2029	1975
query3	10600	4016	3954	3954
query4	59251	24603	23267	23267
query5	5466	517	509	509
query6	417	170	180	170
query7	5786	291	291	291
query8	286	211	227	211
query9	9068	2507	2492	2492
query10	515	272	268	268
query11	18298	14951	15354	14951
query12	159	108	108	108
query13	1567	384	383	383
query14	11164	7631	7418	7418
query15	237	178	179	178
query16	7419	461	452	452
query17	1175	567	603	567
query18	1739	309	312	309
query19	273	153	148	148
query20	117	111	111	111
query21	221	109	108	108
query22	4714	4395	4612	4395
query23	34226	33868	34028	33868
query24	5970	2865	2912	2865
query25	545	413	405	405
query26	693	156	155	155
query27	1777	280	281	280
query28	3823	2120	2098	2098
query29	663	428	434	428
query30	192	155	153	153
query31	953	777	828	777
query32	85	52	63	52
query33	433	281	278	278
query34	868	496	481	481
query35	815	737	702	702
query36	1066	918	926	918
query37	145	92	90	90
query38	4023	3925	3949	3925
query39	1443	1438	1400	1400
query40	190	112	118	112
query41	48	45	43	43
query42	117	94	96	94
query43	522	485	487	485
query44	1091	758	753	753
query45	204	167	171	167
query46	1082	779	746	746
query47	1900	1840	1811	1811
query48	363	303	301	301
query49	744	423	416	416
query50	821	408	415	408
query51	7154	7095	7064	7064
query52	101	87	87	87
query53	249	178	183	178
query54	550	455	435	435
query55	74	78	76	76
query56	296	255	254	254
query57	1198	1083	1071	1071
query58	222	218	217	217
query59	3017	2908	2784	2784
query60	301	264	274	264
query61	107	98	98	98
query62	751	636	643	636
query63	218	181	182	181
query64	2770	658	686	658
query65	3256	3148	3132	3132
query66	616	327	330	327
query67	15383	15199	15365	15199
query68	3052	581	592	581
query69	412	276	279	276
query70	1142	1118	1044	1044
query71	342	277	268	268
query72	6132	3984	4032	3984
query73	754	326	333	326
query74	9251	8981	8890	8890
query75	3372	2680	2704	2680
query76	1384	1022	1024	1022
query77	527	320	312	312
query78	9682	9109	9276	9109
query79	1078	548	532	532
query80	687	508	512	508
query81	547	237	237	237
query82	261	148	154	148
query83	176	146	147	146
query84	256	77	75	75
query85	670	286	287	286
query86	306	266	299	266
query87	4494	4262	4291	4262
query88	2988	2333	2303	2303
query89	391	290	282	282
query90	2016	193	194	193
query91	124	100	101	100
query92	59	53	49	49
query93	1058	532	545	532
query94	680	308	293	293
query95	340	259	254	254
query96	602	270	267	267
query97	3206	3069	3095	3069
query98	212	214	200	200
query99	1704	1277	1302	1277
Total cold run time: 305052 ms
Total hot run time: 193784 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.4 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e2864fda9c8a27b21de5c9d4e49cc64dbfefd7bc, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.05	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.49	0.50	0.50
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.06	0.05	0.05
query9	0.55	0.49	0.49
query10	0.55	0.55	0.54
query11	0.16	0.12	0.12
query12	0.15	0.13	0.12
query13	0.62	0.59	0.59
query14	2.05	2.13	2.11
query15	0.88	0.81	0.83
query16	0.36	0.37	0.38
query17	0.97	1.03	1.02
query18	0.20	0.19	0.20
query19	1.85	1.69	1.72
query20	0.01	0.01	0.01
query21	15.38	0.65	0.66
query22	4.51	6.64	2.30
query23	18.30	1.37	1.34
query24	2.18	0.24	0.21
query25	0.16	0.08	0.08
query26	0.26	0.18	0.18
query27	0.08	0.07	0.08
query28	13.15	1.02	0.99
query29	12.62	3.30	3.32
query30	0.25	0.06	0.05
query31	2.88	0.40	0.39
query32	3.25	0.48	0.49
query33	3.02	3.01	2.99
query34	17.00	4.40	4.36
query35	4.44	4.42	4.39
query36	0.66	0.48	0.47
query37	0.18	0.15	0.16
query38	0.16	0.14	0.14
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.04	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.96 s
Total hot run time: 32.4 s

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 9f46335 into apache:master Sep 4, 2024
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Sep 9, 2024
followup apache#38549
If the large_block_len is 0, should not continue reading the block_len.
morningman pushed a commit that referenced this pull request Sep 27, 2024
## Proposed changes
pick prs:
#38549
#40183
#40315

---------

Co-authored-by: Calvin Kirs <kirs@apache.org>
@suxiaogang223 suxiaogang223 deleted the fix_block_decompressor branch October 10, 2024 08:02
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 10, 2024
followup apache#38549
If the large_block_len is 0, should not continue reading the block_len.
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 10, 2024
followup apache#38549
If the large_block_len is 0, should not continue reading the block_len.
morningman pushed a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants