-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](decompressor) consider the large_block_len is 0 #40183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38168 ms |
TPC-DS: Total hot run time: 188306 ms |
ClickBench: Total hot run time: 32.35 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 37872 ms |
TPC-DS: Total hot run time: 187641 ms |
ClickBench: Total hot run time: 32.8 s |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
43627e8 to
e2864fd
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38012 ms |
TPC-DS: Total hot run time: 193784 ms |
ClickBench: Total hot run time: 32.4 s |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
followup apache#38549 If the large_block_len is 0, should not continue reading the block_len.
followup apache#38549 If the large_block_len is 0, should not continue reading the block_len.
followup apache#38549 If the large_block_len is 0, should not continue reading the block_len.
followup #38549
If the large_block_len is 0, should not continue reading the block_len.