Revert "[Improvement](sort) Free sort blocks if this block is exhausted (#39306)" #40211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (merged_rows == batch_size) { | ||
| break; | ||
| } | ||
| if (merged_rows == batch_size) break; |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (merged_rows == batch_size) break; | |
| if (merged_rows == batch_size) { break; | |
| } |
Comment on lines
+31
to
+32
| namespace doris { | ||
| namespace vectorized { |
Contributor
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Suggested change
| namespace doris { | |
| namespace vectorized { | |
| namespace doris::vectorized { |
be/src/vec/runtime/vsorted_run_merger.cpp:33:
- } // namespace vectorized
- } // namespace doris
+ } // namespace doris
Comment on lines
+33
to
+35
| namespace doris { | ||
|
|
||
| namespace vectorized { |
Contributor
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Suggested change
| namespace doris { | |
| namespace vectorized { | |
| namespace doris::vectorized { |
be/src/vec/runtime/vsorted_run_merger.h:107:
- } // namespace vectorized
- } // namespace doris
+ } // namespace doris
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Sep 2, 2024
… exhausted (apache#39306)" (apache#40211)" This reverts commit 1768169.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39956