Skip to content

[chore](cloud) Support starting both meta-service and recycler within single process #40223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 7 commits into from
Sep 4, 2024
Merged

[chore](cloud) Support starting both meta-service and recycler within single process #40223

gavinchou merged 7 commits into from
Sep 4, 2024

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Aug 31, 2024 •
edited
Loading

e.g. the following will start meta-service and recycler within single process.

./bin/start.sh --daemon

the log file will be meta_service.INFO*

and it is the same effect as ./bin/start.sh --meta-service --recycler --daemon

doc PR apache/doris-website#1073

@doris-robot
Copy link

doris-robot commented Aug 31, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou
Copy link
Contributor Author

gavinchou commented Aug 31, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2024

sh-checker report

To get the full details, please check in the job output.

shellcheck errors 
'shellcheck ' found no issues.
shfmt errors 

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- cloud/script/start.sh.orig
+++ cloud/script/start.sh
@@ -134,9 +134,9 @@
 out_file=${DORIS_HOME}/log/${process}.out
 if [[ "${RUN_DAEMON}" -eq 1 ]]; then
     # append 10 blank lines to ensure the following tail -n10 works correctly
-    printf "\n\n\n\n\n\n\n\n\n\n" >> "${out_file}"
-    echo "$(date +'%F %T') try to start ${process}" >> "${out_file}"
-    nohup "${bin}" "$@" >> "${out_file}" 2>&1 &
+    printf "\n\n\n\n\n\n\n\n\n\n" >>"${out_file}"
+    echo "$(date +'%F %T') try to start ${process}" >>"${out_file}"
+    nohup "${bin}" "$@" >>"${out_file}" 2>&1 &
     echo "wait and check ${process} start successfully"
     sleep 3
     tail -n10 "${out_file}" | grep 'successfully started brpc'
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2024

clang-tidy review says "All clean, LGTM! 👍"

gavinchou
gavinchou commented Aug 31, 2024
View reviewed changes
@gavinchou
Copy link
Contributor Author

gavinchou commented Aug 31, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2024

clang-tidy review says "All clean, LGTM! 👍"

airborne12
airborne12 previously approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

PR approved by anyone and no changes requested.

liaoxin01
liaoxin01 previously approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou dismissed stale reviews from liaoxin01 and airborne12 via b30dc54 September 2, 2024 13:58
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
Copy link
Contributor Author

gavinchou commented Sep 2, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
[chore](cloud) Support starting both meta-service and recycler within…
e1e081e 
… single process

e.g.
```
./bin/start.sh --recycler --meta-service --daemon
```

the log file will be meta_service.INFO*
@gavinchou
Update cloud/script/start.sh
402ed72
@gavinchou
support start 2 roles by default
367fcdc
@gavinchou
format
67dbd59
@gavinchou
fix UT
02da207
@gavinchou gavinchou force-pushed the gavin-support-ms-re-start branch from 8b0a1cb to 02da207 Compare September 2, 2024 16:44
@gavinchou
Copy link
Contributor Author

gavinchou commented Sep 2, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
Copy link
Contributor Author

gavinchou commented Sep 3, 2024

run buildall

gavinchou
gavinchou commented Sep 3, 2024
View reviewed changes
@gavinchou
Copy link
Contributor Author

gavinchou commented Sep 3, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2024
@gavinchou gavinchou merged commit d177d5b into apache:master Sep 4, 2024
gavinchou added a commit that referenced this pull request Sep 5, 2024
@gavinchou
[chore](cloud) Support starting both meta-service and recycler within…
eda09de 
… single process (#40223)

e.g. the following will start meta-service and recycler within single
process.
```
./bin/start.sh --daemon
```
the log file will be meta_service.INFO*

and it is the same effect as `./bin/start.sh --meta-service --recycler
--daemon`

doc PR apache/doris-website#1073
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

@airborne12 airborne12 airborne12 left review comments

@liaoxin01 liaoxin01 liaoxin01 left review comments

+1 more reviewer

@bobhan1 bobhan1 bobhan1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gavinchou @doris-robot @airborne12 @liaoxin01 @bobhan1 @dataroaring