Skip to content

[improvement](jdbc catalog)Optimize JDBC Catalog refresh to reduce frequent client creation. #40261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Sep 2, 2024
Merged

[improvement](jdbc catalog)Optimize JDBC Catalog refresh to reduce frequent client creation. #40261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4770494
[improvement](jdbc catalog)Optimize JDBC Catalog refresh to reduce fr…
zy-kkk Sep 2, 2024
9a28469
fix ut
zy-kkk Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,18 +101,17 @@ public void checkProperties() throws DdlException {
}

@Override
public void onRefresh(boolean invalidCache) {
super.onRefresh(invalidCache);
if (jdbcClient != null) {
jdbcClient.closeClient();
}
public void notifyPropertiesUpdated(Map<String, String> updatedProps) {
super.notifyPropertiesUpdated(updatedProps);
this.onClose();
}

@Override
public void onClose() {
super.onClose();
if (jdbcClient != null) {
jdbcClient.closeClient();
jdbcClient = null;
}
}

Expand Down Expand Up @@ -205,6 +204,9 @@ public boolean isTestConnection() {

@Override
protected void initLocalObjectsImpl() {
if (jdbcClient != null) {
return;
}
JdbcClientConfig jdbcClientConfig = new JdbcClientConfig()
.setCatalog(this.name)
.setUser(getJdbcUser())
Expand Down