[fix](pipelinex) fix fragment instance progress reports #40325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Sep 3, 2024
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Sep 3, 2024
TPC-H: Total hot run time: 38440 ms |
TPC-DS: Total hot run time: 187205 ms |
ClickBench: Total hot run time: 32.34 s |
kaijchen
force-pushed
the
DORIS-12389
branch
from
745d41d to
7b1cae2
Compare
kaijchen
changed the title
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 38155 ms |
TPC-DS: Total hot run time: 192550 ms |
ClickBench: Total hot run time: 32.1 s |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38797 ms |
TPC-DS: Total hot run time: 188284 ms |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 38143 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 194854 ms |
ClickBench: Total hot run time: 31.89 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Sep 5, 2024
## Proposed changes Fix progress in `show load` not 100% when load finished. PipelineX has deprecated `fragmentInstanceId` in `TReportExecStatusParams`. The `finishedScanNums` should be reported with distinct `fragmentInstanceId` to prevent being overwritten. Before ``` | 38024 | lineitem_dup_1_replication_s3_2 | FINISHED | 30.00% (3/10) | BROKER | ... ``` After ``` | 39025 | lineitem_dup_1_replication_s3_3 | FINISHED | 100.00% (10/10) | BROKER | ... ```
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Sep 19, 2024
Fix progress in `show load` not 100% when load finished. PipelineX has deprecated `fragmentInstanceId` in `TReportExecStatusParams`. The `finishedScanNums` should be reported with distinct `fragmentInstanceId` to prevent being overwritten. Before ``` | 38024 | lineitem_dup_1_replication_s3_2 | FINISHED | 30.00% (3/10) | BROKER | ... ``` After ``` | 39025 | lineitem_dup_1_replication_s3_3 | FINISHED | 100.00% (10/10) | BROKER | ... ```
yiguolei
pushed a commit
that referenced
this pull request
Sep 19, 2024
gavinchou
pushed a commit
that referenced
this pull request
Sep 25, 2024
) ## Proposed changes This PR is a followup of #40325. Because PipelineX has deprecated the old report. This PR fixed the `ScannedRows` and `LoadBytes` in the progress of the `SHOW LOAD` result. Currently the progress will only be updated when a fragment instance is done. Timely progress updates will be supported in a later PR.
gavinchou
pushed a commit
that referenced
this pull request
Sep 25, 2024
) ## Proposed changes This PR is a followup of #40325. Because PipelineX has deprecated the old report. This PR fixed the `ScannedRows` and `LoadBytes` in the progress of the `SHOW LOAD` result. Currently the progress will only be updated when a fragment instance is done. Timely progress updates will be supported in a later PR.
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Oct 10, 2024
…che#40694) This PR is a followup of apache#40325. Because PipelineX has deprecated the old report. This PR fixed the `ScannedRows` and `LoadBytes` in the progress of the `SHOW LOAD` result. Currently the progress will only be updated when a fragment instance is done. Timely progress updates will be supported in a later PR.
Closed
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Oct 16, 2024
…che#40694) This PR is a followup of apache#40325. Because PipelineX has deprecated the old report. This PR fixed the `ScannedRows` and `LoadBytes` in the progress of the `SHOW LOAD` result. Currently the progress will only be updated when a fragment instance is done. Timely progress updates will be supported in a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix progress in
show loadnot 100% when load finished.PipelineX has deprecated
fragmentInstanceIdinTReportExecStatusParams.The
finishedScanNumsshould be reported with distinctfragmentInstanceIdto prevent being overwritten.Before
After