[feat](nereids)set actual row count in physical plan according to merged profile #40361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37803 ms |
TPC-DS: Total hot run time: 192644 ms |
ClickBench: Total hot run time: 31.98 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38125 ms |
TPC-DS: Total hot run time: 187087 ms |
ClickBench: Total hot run time: 31.9 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37522 ms |
TPC-DS: Total hot run time: 193101 ms |
ClickBench: Total hot run time: 31.49 s |
starocean999
approved these changes
Sep 9, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Mryange
approved these changes
Sep 9, 2024
Contributor
|
Can we pick this pr to branch-3.0 ? |
Contributor
Author
|
not-merge/2.1 |
Contributor
Author
YES |
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
Oct 22, 2024
…ged profile (apache#40361) physical plan is already printed in profile. however, it is hard to compare the estimated rows of sql operator and the actual rows. In this pr, we get actual rows from merged profile, and set it to corresponding physical node in physical plan. here is an example: "PhysicalHashJoin[13890]@115 ( stats=17,964.27 actualRows=20499, type=INNER_JOIN, hashCondition=[(l_suppkey#19 = s_suppkey#33)]" the estmated rows is 17,964, the actual rows is 20499 Issue Number: close #xxx <!--Describe your changes.-->
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
Oct 22, 2024
…ged profile (apache#40361) physical plan is already printed in profile. however, it is hard to compare the estimated rows of sql operator and the actual rows. In this pr, we get actual rows from merged profile, and set it to corresponding physical node in physical plan. here is an example: "PhysicalHashJoin[13890]@115 ( stats=17,964.27 actualRows=20499, type=INNER_JOIN, hashCondition=[(l_suppkey#19 = s_suppkey#33)]" the estmated rows is 17,964, the actual rows is 20499 Issue Number: close #xxx <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
physical plan is already printed in profile.
however, it is hard to compare the estimated rows of sql operator and the actual rows.
In this pr, we get actual rows from merged profile, and set it to corresponding physical node in physical plan.
here is an example:
"PhysicalHashJoin[13890]@115 ( stats=17,964.27 actualRows=20499, type=INNER_JOIN, hashCondition=[(l_suppkey#19 = s_suppkey#33)]"
the estmated rows is 17,964, the actual rows is 20499
Issue Number: close #xxx