Skip to content

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Sep 5, 2024

is_exclusive in column_array/map/struct has wrong semantic , we should make sure it's nested column is also is_exclusive which can make behavior right in some operator like join.

Proposed changes

backport: #40398
Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

amorynan commented Sep 5, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

amorynan commented Sep 9, 2024

run p0

@amorynan
Copy link
Contributor Author

amorynan commented Sep 9, 2024

run beut

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

amorynan commented Sep 9, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

amorynan commented Sep 9, 2024

run buildall

@yiguolei
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.16% (9321/25779)
Line Coverage: 27.72% (76462/275881)
Region Coverage: 26.52% (39272/148106)
Branch Coverage: 23.34% (20033/85820)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c89ced08507328c39aa89ee9d996e60afb9ea231_c89ced08507328c39aa89ee9d996e60afb9ea231/report/index.html

amory added 2 commits September 16, 2024 00:09
is_exclusive in column_array/map/struct has wrong semantic , we should
make sure it's nested column is also is_exclusive which can make
behavior right in some operator like join.
@yiguolei
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.16% (9328/25797)
Line Coverage: 27.71% (76600/276447)
Region Coverage: 26.50% (39322/148395)
Branch Coverage: 23.31% (20044/85996)
Coverage Report: http://coverage.selectdb-in.cc/coverage/74188a81f994bbbd8e3514505d6f7c687892092c_74188a81f994bbbd8e3514505d6f7c687892092c/report/index.html

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.17% (9331/25799)
Line Coverage: 27.72% (76625/276463)
Region Coverage: 26.51% (39366/148495)
Branch Coverage: 23.31% (20046/86014)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e8a06173b75cb197335ff4dcd38bb553bc1c6fa4_e8a06173b75cb197335ff4dcd38bb553bc1c6fa4/report/index.html

@hello-stephen
Copy link
Contributor

run external

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.17% (9331/25799)
Line Coverage: 27.72% (76633/276463)
Region Coverage: 26.51% (39368/148495)
Branch Coverage: 23.31% (20047/86014)
Coverage Report: http://coverage.selectdb-in.cc/coverage/313c45bed5226b47b0946eb62dd81e33671aaa50_313c45bed5226b47b0946eb62dd81e33671aaa50/report/index.html

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit f483a76 into apache:branch-2.1 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants