Skip to content

Conversation

@xiaokang
Copy link
Contributor

@xiaokang xiaokang commented Sep 5, 2024

Proposed changes

Do not set label when group_commit is set in headers.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xiaokang
Copy link
Contributor Author

xiaokang commented Sep 5, 2024

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit f09f4a4 into apache:master Sep 6, 2024
@xiaokang xiaokang changed the title [fix](logstash) fix group_commit error in logstash [fix](logstash) fix group_commit error in logstash doris output plugin Sep 6, 2024
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
Do not set label when group_commit is set in headers.
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants